Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 554523003: Fix git-map-branches crashing on HEAD, and other minor quality-of-life (Closed)

Created:
6 years, 3 months ago by iannucci
Modified:
6 years, 3 months ago
Reviewers:
calamity, agable, jsbell
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Fix git-map-branches crashing on HEAD, and other minor quality-of-life improvements. * No longer crash on HEAD * Always correctly highlight lines based on hash-matching-ness * Only import git_cl if you want it (it can be slow) * Print a message when NO branches are found (instead of blank output) R=calamity@chromium.org, jsbell@chromium.org BUG=410353 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291847

Patch Set 1 #

Patch Set 2 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -9 lines) Patch
M git_map_branches.py View 1 5 chunks +16 lines, -9 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
iannucci
6 years, 3 months ago (2014-09-07 18:55:11 UTC) #1
iannucci
+agable to PTAL
6 years, 3 months ago (2014-09-07 18:56:10 UTC) #3
calamity
lgtm. Thanks for fixing!
6 years, 3 months ago (2014-09-08 01:13:56 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/iannucci@chromium.org/554523003/20001
6 years, 3 months ago (2014-09-08 02:10:34 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-08 02:12:26 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 291847

Powered by Google App Engine
This is Rietveld 408576698