Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(98)

Issue 554523002: Fixed NO_MIC_DATA error on Mac. (Closed)

Created:
6 years, 3 months ago by no longer working on chromium
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed NO_DATA_ERROR on Mac. I wrote two unittests which open the device, wait for the data callback, then close the device, ran the tests in an infinite loop, after several hours, it hits NO_MIC_DATA on the input side. The problem is that sometimes the audio unit gets corrupted, and our input code does not correctly dispose the unit component, so the broken audio unit can be leaked and prevent the OS pumping audio callback to all auido units. This patch fixes two problems: 1, AUAudioInputStream::Close() is not completely correct, we need to call AudioComponentInstanceDispose() 2, It seems that we should setup the input callback before setting the formats, which might not be correct (I am not really sure, but the tests show that I was able to restart the stream after changing it) BUG=411869 Committed: https://crrev.com/9bb4136278a98e27d1c47e97fb3a4f496a97ca8c Cr-Commit-Position: refs/heads/master@{#293725}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -20 lines) Patch
M media/audio/mac/audio_low_latency_input_mac.cc View 3 chunks +24 lines, -20 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
no longer working on chromium
Tommi, I believe it is OK to land this? I have been running tests with ...
6 years, 3 months ago (2014-09-08 12:51:03 UTC) #2
tommi (sloooow) - chröme
lgtm
6 years, 3 months ago (2014-09-08 14:00:29 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/xians@chromium.org/554523002/1
6 years, 3 months ago (2014-09-08 14:05:21 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as 803a2527f7810fadfd2a193189e6edf159eaf5ac
6 years, 3 months ago (2014-09-08 15:04:03 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:46:18 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/9bb4136278a98e27d1c47e97fb3a4f496a97ca8c
Cr-Commit-Position: refs/heads/master@{#293725}

Powered by Google App Engine
This is Rietveld 408576698