Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(565)

Issue 554363005: GN: Replace mojo/system.gni with forwarding groups (Closed)

Created:
6 years, 3 months ago by jamesr
Modified:
6 years, 3 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org, cc-bugs_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

GN: Replace mojo/system.gni with forwarding groups Many targets in mojo need to depend on different targets depending on if they are building in the static or component build. In gyp, this is done with variables (since that's the only thing you have) and the GN build initially copied these variables into //mojo/system.gni. This worked, but is not very idomatic in GN. This replaces the variables with groups that forward to the correct depenedency depending on the build type and target type (encoded in the target name). R=brettw@chromium.org, viettrungluu@chromium.org Committed: https://crrev.com/bef0b9045da427c4f2212a5aeb0a878eddee0edc Cr-Commit-Position: refs/heads/master@{#295137}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -138 lines) Patch
M media/mojo/services/BUILD.gn View 2 chunks +1 line, -4 lines 0 comments Download
M mojo/apps/js/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/apps/js/bindings/gl/BUILD.gn View 1 chunk +3 lines, -4 lines 0 comments Download
M mojo/aura/BUILD.gn View 2 chunks +3 lines, -4 lines 0 comments Download
M mojo/cc/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/common/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/examples/apptest/BUILD.gn View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/examples/aura_demo/BUILD.gn View 3 chunks +4 lines, -3 lines 0 comments Download
M mojo/examples/browser/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/compositor_app/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/content_handler_demo/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/examples/dbus_echo/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/examples/demo_launcher/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M mojo/examples/echo/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/examples/embedded_app/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/keyboard/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/media_viewer/BUILD.gn View 3 chunks +2 lines, -2 lines 0 comments Download
M mojo/examples/nesting_app/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/examples/pepper_container_app/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/examples/png_viewer/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/examples/sample_app/BUILD.gn View 1 3 chunks +5 lines, -4 lines 0 comments Download
M mojo/examples/surfaces_app/BUILD.gn View 4 chunks +7 lines, -4 lines 0 comments Download
M mojo/examples/wget/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/examples/window_manager/BUILD.gn View 3 chunks +3 lines, -2 lines 0 comments Download
M mojo/examples/wm_flow/BUILD.gn View 5 chunks +8 lines, -5 lines 0 comments Download
M mojo/gles2/BUILD.gn View 1 2 chunks +1 line, -2 lines 0 comments Download
M mojo/public/c/system/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/public/gles2/BUILD.gn View 1 chunk +26 lines, -0 lines 0 comments Download
M mojo/services/html_viewer/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/native_viewport/BUILD.gn View 1 chunk +0 lines, -1 line 0 comments Download
M mojo/services/network/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/cpp/geometry/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/input_events/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M mojo/services/public/cpp/surfaces/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/public/cpp/view_manager/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/surfaces/BUILD.gn View 2 chunks +3 lines, -3 lines 0 comments Download
M mojo/services/test_service/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/view_manager/BUILD.gn View 3 chunks +2 lines, -3 lines 0 comments Download
M mojo/services/window_manager/BUILD.gn View 2 chunks +2 lines, -3 lines 0 comments Download
D mojo/system.gni View 1 chunk +0 lines, -28 lines 0 comments Download

Messages

Total messages: 13 (4 generated)
jamesr
acolwell@ - media/mojo/services/BUILD.gn viettrungluu@ - mojo/ brettw@ - GN-foo
6 years, 3 months ago (2014-09-15 19:50:48 UTC) #2
acolwell GONE FROM CHROMIUM
lgtm for media/mojo/services/BUILD.gn
6 years, 3 months ago (2014-09-15 20:31:25 UTC) #3
viettrungluu
lgtm
6 years, 3 months ago (2014-09-15 21:47:50 UTC) #4
brettw
concept lgtm, I didn't look at the code.
6 years, 3 months ago (2014-09-16 16:48:06 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554363005/1
6 years, 3 months ago (2014-09-16 16:51:38 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/4849) android_clang_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_clang_dbg_recipe/builds/4709) chromium_presubmit ...
6 years, 3 months ago (2014-09-16 16:58:26 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554363005/20001
6 years, 3 months ago (2014-09-16 19:24:55 UTC) #11
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 4390ec9dc6f70908db2ac24b8827db3259f65bb1
6 years, 3 months ago (2014-09-16 20:23:51 UTC) #12
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 20:24:26 UTC) #13
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/bef0b9045da427c4f2212a5aeb0a878eddee0edc
Cr-Commit-Position: refs/heads/master@{#295137}

Powered by Google App Engine
This is Rietveld 408576698