Modify CustomElementProcessingStep::isCreated()'s name

Modify CustomElementProcessingStep::isCreated()'s name

Rename CustomElementProcessingStep::isCreated() to isCreatedCallback()
to reflect that callback is created callback.

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=182033

[deepak.sa, 2014-09-10 08:34:03]

deepak.sa@samsung.com changed reviewers:
+ dominicc@chromium.org

[deepak.sa, 2014-09-10 08:34:03]

PTAL?
Thanks!

[dominicc (has gone to gerrit), 2014-09-11 06:16:56]

On 2014/09/10 08:34:03, deepak.sa wrote:
> PTAL?
> Thanks!

Not LGTM.

Whether the processing stack is "in" (executing) the created callback is a
dynamic condition. Whether the callback is the created callback or not is fixed
for the callback. So the existing method and variable names are just right. The
isInCreatedCallback method name in particular is misleading.

[deepak.sa, 2014-09-11 06:46:26]

On 2014/09/11 06:16:56, dominicc wrote:
> On 2014/09/10 08:34:03, deepak.sa wrote:
> > PTAL?
> > Thanks!
> 
> Not LGTM.
> 
> Whether the processing stack is "in" (executing) the created callback is a
> dynamic condition. Whether the callback is the created callback or not is
fixed
> for the callback. So the existing method and variable names are just right.
The
> isInCreatedCallback method name in particular is misleading.

Ok! This effort was to reflect the usage of the function. As it was used here:
"m_inCreatedCallback = m_queue[m_index]->isCreated();"
So, i thought it might be better to rename the function. 
IMHO, "isCreated()" seems unclear. May be "isCreatedCallback()" then?

[dominicc (has gone to gerrit), 2014-09-11 06:59:00]

On 2014/09/11 06:46:26, deepak.sa wrote:
> On 2014/09/11 06:16:56, dominicc wrote:
> > On 2014/09/10 08:34:03, deepak.sa wrote:
> > > PTAL?
> > > Thanks!
> > 
> > Not LGTM.
> > 
> > Whether the processing stack is "in" (executing) the created callback is a
> > dynamic condition. Whether the callback is the created callback or not is
> fixed
> > for the callback. So the existing method and variable names are just right.
> The
> > isInCreatedCallback method name in particular is misleading.
> 
> Ok! This effort was to reflect the usage of the function. As it was used here:
> "m_inCreatedCallback = m_queue[m_index]->isCreated();"
> So, i thought it might be better to rename the function. 
> IMHO, "isCreated()" seems unclear. May be "isCreatedCallback()" then?

Sure, isCreatedCallback makes sense.

[deepak.sa, 2014-09-11 07:27:43]

On 2014/09/11 06:59:00, dominicc wrote:
> On 2014/09/11 06:46:26, deepak.sa wrote:
> > On 2014/09/11 06:16:56, dominicc wrote:
> > > On 2014/09/10 08:34:03, deepak.sa wrote:
> > > > PTAL?
> > > > Thanks!
> > > 
> > > Not LGTM.
> > > 
> > > Whether the processing stack is "in" (executing) the created callback is a
> > > dynamic condition. Whether the callback is the created callback or not is
> > fixed
> > > for the callback. So the existing method and variable names are just
right.
> > The
> > > isInCreatedCallback method name in particular is misleading.
> > 
> > Ok! This effort was to reflect the usage of the function. As it was used
here:
> > "m_inCreatedCallback = m_queue[m_index]->isCreated();"
> > So, i thought it might be better to rename the function. 
> > IMHO, "isCreated()" seems unclear. May be "isCreatedCallback()" then?
> 
> Sure, isCreatedCallback makes sense.

Uploaded a new patchset.
Please have a look!
Thanks!

[deepak.sa, 2014-09-15 16:20:33]

Ping!

[dominicc (has gone to gerrit), 2014-09-16 01:19:23]

The CQ bit was checked by dominicc@chromium.org

[dominicc (has gone to gerrit), 2014-09-16 01:19:23]

lgtm

[commit-bot: I haz the power, 2014-09-16 01:19:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/554333002/20001

[commit-bot: I haz the power, 2014-09-16 01:25:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-16 01:25:48]

Try jobs failed on following builders:
  mac_blink_compile_dbg on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_compile_dbg/bu...)
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/23474)

[deepak.sa, 2014-09-16 05:23:55]

The CQ bit was checked by deepak.sa@samsung.com

[commit-bot: I haz the power, 2014-09-16 05:25:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/554333002/20001

[commit-bot: I haz the power, 2014-09-16 06:20:40]

Committed patchset #2 (id:20001) as 182033