Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 55433006: Explicitly reject storage access if requesting security origin is unique (Closed)

Created:
7 years, 1 month ago by kinuko
Modified:
7 years, 1 month ago
Reviewers:
michaeln, jam
CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, jam
Visibility:
Public.

Description

Explicitly reject storage access if requesting security origin is unique This is a follow-up fix for https://codereview.chromium.org/46583005/ (Send Allow{Database,FileSystem,IndexedDB} sync IPCs directly from worker threads) I needed to default behavior to allow storage access when NULL proxy is returned to make content_shell work, and therefore needed not to return NULL when origin.isUnique()==true case. BUG=none R=jam,michaeln TBR=jam Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232922

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -3 lines) Patch
M content/worker/shared_worker_permission_client_proxy.h View 2 chunks +2 lines, -0 lines 0 comments Download
M content/worker/shared_worker_permission_client_proxy.cc View 4 chunks +8 lines, -0 lines 0 comments Download
M content/worker/websharedworkerclient_proxy.cc View 1 chunk +1 line, -3 lines 1 comment Download

Messages

Total messages: 12 (0 generated)
kinuko
Sorry, I needed this small fix to make the blink code default to 'allow' if ...
7 years, 1 month ago (2013-11-01 09:37:58 UTC) #1
michaeln
lgtm https://codereview.chromium.org/55433006/diff/1/content/worker/websharedworkerclient_proxy.cc File content/worker/websharedworkerclient_proxy.cc (left): https://codereview.chromium.org/55433006/diff/1/content/worker/websharedworkerclient_proxy.cc#oldcode85 content/worker/websharedworkerclient_proxy.cc:85: return NULL; right... no proxy means "allowed" by ...
7 years, 1 month ago (2013-11-01 18:22:45 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/55433006/1
7 years, 1 month ago (2013-11-04 03:39:58 UTC) #3
commit-bot: I haz the power
Retried try job too often on chromium_presubmit for step(s) presubmit http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_presubmit&number=34180
7 years, 1 month ago (2013-11-04 03:58:39 UTC) #4
kinuko
TBR-ing jam for content/ owner stamp.
7 years, 1 month ago (2013-11-04 04:29:09 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/55433006/1
7 years, 1 month ago (2013-11-04 04:29:27 UTC) #6
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97072
7 years, 1 month ago (2013-11-04 07:04:26 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/55433006/1
7 years, 1 month ago (2013-11-04 13:56:19 UTC) #8
commit-bot: I haz the power
Retried try job too often on win7_aura for step(s) browser_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win7_aura&number=97219
7 years, 1 month ago (2013-11-04 16:18:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/55433006/1
7 years, 1 month ago (2013-11-05 01:14:18 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinuko@chromium.org/55433006/1
7 years, 1 month ago (2013-11-05 03:17:14 UTC) #11
commit-bot: I haz the power
7 years, 1 month ago (2013-11-05 06:00:32 UTC) #12
Message was sent while issue was closed.
Change committed as 232922

Powered by Google App Engine
This is Rietveld 408576698