Propagates the search result of start page to the app-list search box.

Propagates the search result of start page to the app-list search box.

BUG=313899
R=xiyuan@chromium.org
TEST=manually

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=234685

[xiyuan, 2013-11-01 04:24:11]

https://codereview.chromium.org/55433002/diff/1/chrome/browser/ui/app_list/st...
File chrome/browser/ui/app_list/start_page_service.h (right):

https://codereview.chromium.org/55433002/diff/1/chrome/browser/ui/app_list/st...
chrome/browser/ui/app_list/start_page_service.h:63: AppListModel* model_;
I don't like to put the weak reference to model here.

Would the following way work?
- Add a StartPageServiceObserver interface with a OnSearch (or
OnSpeechRecognized) method;
- Make AppListViewDelegate such an observer and observes StartPageService
- When StartPageHandler needs to handle "search" (or "speechRecognized")
message, it finds StartPageService and notifies the observers;
- AppListViewDelegate have access to the model and can update searchbox model to
trigger the search

What do you think?

[Jun Mukai, 2013-11-01 17:25:24]

https://codereview.chromium.org/55433002/diff/1/chrome/browser/ui/app_list/st...
File chrome/browser/ui/app_list/start_page_service.h (right):

https://codereview.chromium.org/55433002/diff/1/chrome/browser/ui/app_list/st...
chrome/browser/ui/app_list/start_page_service.h:63: AppListModel* model_;
On 2013/11/01 04:24:12, xiyuan wrote:
> I don't like to put the weak reference to model here.
> 
> Would the following way work?
> - Add a StartPageServiceObserver interface with a OnSearch (or
> OnSpeechRecognized) method;
> - Make AppListViewDelegate such an observer and observes StartPageService
> - When StartPageHandler needs to handle "search" (or "speechRecognized")
> message, it finds StartPageService and notifies the observers;
> - AppListViewDelegate have access to the model and can update searchbox model
to
> trigger the search
> 
> What do you think?

Agreed, done.  PTAL.

[xiyuan, 2013-11-01 17:28:56]

Cool. LGTM.

https://codereview.chromium.org/55433002/diff/60001/chrome/browser/ui/app_lis...
File chrome/browser/ui/app_list/start_page_observer.h (right):

https://codereview.chromium.org/55433002/diff/60001/chrome/browser/ui/app_lis...
chrome/browser/ui/app_list/start_page_observer.h:16: };
nit:
protected:
  virtual ~StartPageObserver() {}

[Jun Mukai, 2013-11-01 18:37:38]

https://codereview.chromium.org/55433002/diff/60001/chrome/browser/ui/app_lis...
File chrome/browser/ui/app_list/start_page_observer.h (right):

https://codereview.chromium.org/55433002/diff/60001/chrome/browser/ui/app_lis...
chrome/browser/ui/app_list/start_page_observer.h:16: };
On 2013/11/01 17:28:56, xiyuan wrote:
> nit:
> protected:
>   virtual ~StartPageObserver() {}

Done.

[commit-bot: I haz the power, 2013-11-11 18:00:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/55433002/120001

[commit-bot: I haz the power, 2013-11-11 18:15:40]

Retried try job too often on chromium_presubmit for step(s) presubmit
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=chromium_p...

[commit-bot: I haz the power, 2013-11-11 18:19:30]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/55433002/120001

[commit-bot: I haz the power, 2013-11-11 19:16:03]

Sorry for I got bad news for ya.
Compile failed with a clobber build on win.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...
Your code is likely broken or HEAD is junk. Please ensure your
code is not broken then alert the build sheriffs.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2013-11-11 21:47:06]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/55433002/120001

[commit-bot: I haz the power, 2013-11-12 23:30:35]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/mukai@chromium.org/55433002/120001

[commit-bot: I haz the power, 2013-11-13 00:58:11]

Change committed as 234685