Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issue 554303002: CSP: Separate more parse-time side-effects. (Closed)

Created:
6 years, 3 months ago by Mike West
Modified:
6 years, 3 months ago
CC:
blink-reviews
Project:
blink
Visibility:
Public.

Description

CSP: Separate more parse-time side-effects. This patch does two things: * The single parse-time UseCounter is now out of the parsing flow, and in the side-effects method. * Parse-time ConsoleMessages generated in ContentSecurityPolicy and CSPDirectiveList are now stored on ContentSecurityPolicy and spun out to the console in the side-effects method. BUG=411889 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181715

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+60 lines, -48 lines) Patch
M Source/core/frame/csp/CSPDirective.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/csp/CSPDirectiveList.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.h View 5 chunks +20 lines, -15 lines 0 comments Download
M Source/core/frame/csp/ContentSecurityPolicy.cpp View 7 chunks +36 lines, -29 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Mike West
Mind taking a look? -mike
6 years, 3 months ago (2014-09-09 13:28:33 UTC) #2
jochen (gone - plz use gerrit)
lgtm
6 years, 3 months ago (2014-09-10 08:03:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mkwst@chromium.org/554303002/1
6 years, 3 months ago (2014-09-10 08:10:30 UTC) #5
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 08:47:43 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181715

Powered by Google App Engine
This is Rietveld 408576698