Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(537)

Issue 554293003: [CSS Grid Layout] RenderGrid methods should take RenderBox references (Closed)

Created:
6 years, 3 months ago by svillar
Modified:
6 years, 3 months ago
CC:
blink-reviews, blink-reviews-rendering, eae+blinkwatch, jchaffraix+rendering, jfernandez, leviw+renderwatch, pdr., Manuel Rego, rune+blink, svillar, zoltan1
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Project:
blink
Visibility:
Public.

Description

[CSS Grid Layout] RenderGrid methods should take RenderBox references RenderGrid has several methods that take pointers to RenderBox instances but the body of those methods assumes that the objects will never be NULL. We should replace them by references. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181722

Patch Set 1 #

Patch Set 2 : Patch for landing #

Unified diffs Side-by-side diffs Delta from patch set Stats (+107 lines, -107 lines) Patch
M Source/core/rendering/RenderGrid.h View 3 chunks +24 lines, -24 lines 0 comments Download
M Source/core/rendering/RenderGrid.cpp View 1 29 chunks +83 lines, -83 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
svillar
Adding some OWNERS
6 years, 3 months ago (2014-09-09 14:59:49 UTC) #2
Julien - ping for review
rs lgtm
6 years, 3 months ago (2014-09-09 23:21:28 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/554293003/1
6 years, 3 months ago (2014-09-09 23:22:23 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/53720)
6 years, 3 months ago (2014-09-09 23:32:08 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/svillar@igalia.com/554293003/20001
6 years, 3 months ago (2014-09-10 09:17:57 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 10:18:31 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 181722

Powered by Google App Engine
This is Rietveld 408576698