Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(341)

Issue 554283004: Fixed path of unstripped libs in CreateSymFs (Closed)

Created:
6 years, 3 months ago by perezju
Modified:
6 years, 3 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Fixed path of unstripped libs in CreateSymFs Paths of stripped libs in the device used to look like: /data/app-lib/*/*.so But they now look like /data/app/*/.../*.so This patch fixes this function, so that now its associated unittest (the most time consuming one in telemetry) does not fail. BUG=396367 Committed: https://crrev.com/6283bb93ac1b7ff9286ce665c8f478a7b2e5ff3b Cr-Commit-Position: refs/heads/master@{#294813}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper.py View 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/android_profiling_helper_unittest.py View 2 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
perezju
6 years, 3 months ago (2014-09-15 12:35:16 UTC) #2
Sami
Thanks, lgtm!
6 years, 3 months ago (2014-09-15 12:39:33 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/554283004/1
6 years, 3 months ago (2014-09-15 12:41:20 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1) as bfed2e4ce4625d8c8f2ac5655ac8d87fe06919c0
6 years, 3 months ago (2014-09-15 13:41:22 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 15:08:23 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/6283bb93ac1b7ff9286ce665c8f478a7b2e5ff3b
Cr-Commit-Position: refs/heads/master@{#294813}

Powered by Google App Engine
This is Rietveld 408576698