Refactored bisect results dicts into a separate class

tools/auto_bisect/bisect_perf_regression_test.py

Index: tools/auto_bisect/bisect_perf_regression_test.py
diff --git a/tools/auto_bisect/bisect_perf_regression_test.py b/tools/auto_bisect/bisect_perf_regression_test.py
index fd321b481f012fd59fadd7a19ad1e6c37299e9c0..5fba2c93e3550efacd02f72c7dbe8a8105f2f27d 100644
--- a/tools/auto_bisect/bisect_perf_regression_test.py
+++ b/tools/auto_bisect/bisect_perf_regression_test.py
@@ -8,6 +8,7 @@ import shutil
 import unittest
 
 import bisect_perf_regression
+import bisect_results
 import source_control as source_control_module
 
 
@@ -33,6 +34,12 @@ def _GetBisectPerformanceMetricsInstance():
 class BisectPerfRegressionTest(unittest.TestCase):
   """Test case for other functions and classes in bisect-perf-regression.py."""
 
+  def setUp(self):
+    self.cwd = os.getcwd()
+
+  def tearDown(self):
+    os.chdir(self.cwd)
+
   def _AssertConfidence(self, score, bad_values, good_values):
     """Checks whether the given sets of values have a given confidence score.
 
@@ -47,7 +54,7 @@ class BisectPerfRegressionTest(unittest.TestCase):
     """
     # ConfidenceScore takes a list of lists but these lists are flattened
     # inside the function.
-    confidence = bisect_perf_regression.ConfidenceScore(
+    confidence = bisect_results.ConfidenceScore(
         [[v] for v in bad_values],
         [[v] for v in good_values])
     self.assertEqual(score, confidence)
@@ -289,7 +296,7 @@ class BisectPerfRegressionTest(unittest.TestCase):
 
   def testUpdateDepsContent(self):
     bisect_instance = _GetBisectPerformanceMetricsInstance()
-    deps_file = 'DEPS'
+    deps_file = os.path.join(bisect_perf_regression.SRC_DIR, 'DEPS')
     # We are intentionally reading DEPS file contents instead of string literal
     # with few lines from DEPS because to check if the format we are expecting
     # to search is not changed in DEPS content.
@@ -306,5 +313,43 @@ class BisectPerfRegressionTest(unittest.TestCase):
     self.assertIsNotNone(re.search(ss, updated_content))
 
 
+class DepotDirectoryRegistryTest(unittest.TestCase):
+
+  def setUp(self):
+    self.old_src_dir = bisect_perf_regression.SRC_DIR
+    bisect_perf_regression.SRC_DIR = '/mock/src'
+    self.old_chdir = os.chdir
+    os.chdir = self.mockChdir
+    self.old_depot_names = bisect_perf_regression.DEPOT_NAMES
+    bisect_perf_regression.DEPOT_NAMES = ['mock_depot']
+    self.old_depot_deps_name = bisect_perf_regression.DEPOT_DEPS_NAME
+    bisect_perf_regression.DEPOT_DEPS_NAME = {'mock_depot': {'src': 'src/foo'}}
+
+    self.registry = bisect_perf_regression.DepotDirectoryRegistry()
+    self.cur_dir = None
+
+  def tearDown(self):
+    bisect_perf_regression.SRC_DIR = self.old_src_dir
+    os.chdir = self.old_chdir
+    bisect_perf_regression.DEPOT_NAMES = self.old_depot_names
+    bisect_perf_regression.DEPOT_DEPS_NAME = self.old_depot_deps_name
+
+  def mockChdir(self, new_dir):
+    self.cur_dir = new_dir
+
+  def testReturnsCorrectResultForChrome(self):
+    self.assertEqual(self.registry.GetDepotDir('chromium'), '/mock/src')
+
+  def testReturnsCorrectResultForChromeOS(self):
+    self.assertEqual(self.registry.GetDepotDir('cros'), '/mock/src/tools/cros')
+
+  def testUsesDepotSpecToInitializeRegistry(self):
+    self.assertEqual(self.registry.GetDepotDir('mock_depot'), '/mock/src/foo')
+
+  def testChangedTheDirectory(self):
+    self.registry.ChangeToDepotDir('mock_depot')
+    self.assertEqual(self.cur_dir, '/mock/src/foo')
+
+
 if __name__ == '__main__':
   unittest.main()