Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(50)

Issue 554223002: Fixed printing of JS code. (Closed)

Created:
6 years, 3 months ago by Sven Panne
Modified:
6 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev, Vyacheslav Egorov (Chromium)
Project:
v8
Visibility:
Public.

Description

Fixed printing of JS code. This is a fix/improvement for r23478 ("Fix disassembly redirection from stdout into a file."). R=yangguo@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=23792

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -9 lines) Patch
M src/codegen.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ostreams.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/ostreams.cc View 3 chunks +7 lines, -6 lines 0 comments Download

Messages

Total messages: 4 (1 generated)
Sven Panne
6 years, 3 months ago (2014-09-09 09:21:10 UTC) #2
Yang
On 2014/09/09 09:21:10, Sven Panne wrote: lgtm.
6 years, 3 months ago (2014-09-09 09:28:50 UTC) #3
Sven Panne
6 years, 3 months ago (2014-09-09 10:33:42 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as 23792 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698