Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2826)

Unified Diff: chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: include logging.h Created 6 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
diff --git a/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc b/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
index 5abddd00dfa1770214050af209f795452879cfa1..e2d1c6d24875160c85df784035f5a9d08f403dd4 100644
--- a/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
+++ b/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc
@@ -66,16 +66,15 @@ class WebNotificationTrayTest : public InProcessBrowserTest {
const std::string& replace_id) {
::Notification notification(
GURL("chrome-extension://abbccedd"),
- GURL(),
base::ASCIIToUTF16("Test Web Notification"),
base::ASCIIToUTF16("Notification message body."),
- blink::WebTextDirectionDefault,
+ gfx::Image(),
base::string16(),
base::ASCIIToUTF16(replace_id),
new TestNotificationDelegate(delegate_id));
- g_browser_process->notification_ui_manager()->Add(
- notification, browser()->profile());
+ g_browser_process->notification_ui_manager()->Add(notification,
+ browser()->profile());
}
std::string FindNotificationIdByDelegateId(const std::string& delegate_id) {
@@ -90,16 +89,15 @@ class WebNotificationTrayTest : public InProcessBrowserTest {
void UpdateNotification(const std::string& replace_id,
const std::string& new_id) {
::Notification notification(GURL("chrome-extension://abbccedd"),
- GURL(""),
base::ASCIIToUTF16("Updated Web Notification"),
base::ASCIIToUTF16("Updated message body."),
- blink::WebTextDirectionDefault,
+ gfx::Image(),
base::string16(),
base::ASCIIToUTF16(replace_id),
new TestNotificationDelegate(new_id));
- g_browser_process->notification_ui_manager()->Add(
- notification, browser()->profile());
+ g_browser_process->notification_ui_manager()->Add(notification,
+ browser()->profile());
}
void RemoveNotification(const std::string& id) {
« no previous file with comments | « chrome/browser/notifications/notification_test_util.cc ('k') | content/common/desktop_notification_messages.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698