content/public/common/show_desktop_notification_params.h - Issue 554213003: Request the icon of a Web Notification in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/common/show_desktop_notification_params.h

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/desktop_notification_service.cc ('K') | « content/common/desktop_notification_messages.h ('k') | content/renderer/notification_provider.h » ('j') | content/renderer/notification_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: content/public/common/show_desktop_notification_params.h

diff --git a/content/public/common/show_desktop_notification_params.h b/content/public/common/show_desktop_notification_params.h

index 327f91cb8b63b5ac5027e639ad108b83737d4083..c601654409a399cef6243a451cd37639185ca4c7 100644

--- a/content/public/common/show_desktop_notification_params.h

+++ b/content/public/common/show_desktop_notification_params.h

@@ -7,6 +7,7 @@

#include "content/common/content_export.h"

#include "third_party/WebKit/public/web/WebTextDirection.h"

+#include "third_party/skia/include/core/SkBitmap.h"

#include "url/gurl.h"

namespace content {

@@ -19,8 +20,9 @@ struct CONTENT_EXPORT ShowDesktopNotificationHostMsgParams {

// URL which is the origin that created this notification.

GURL origin;

- // Contents of the notification if is_html is false.

- GURL icon_url;

+ // Image to be displayed as part of the notification.

+ SkBitmap icon;

base::string16 title;

base::string16 body;