chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc - Issue 554213003: Request the icon of a Web Notification in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/notifications/desktop_notification_service.cc ('K') | « chrome/browser/notifications/notification_test_util.cc ('k') | content/common/desktop_notification_messages.h » ('j') | content/renderer/notification_provider.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

diff --git a/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc b/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

index 9d2a4fd9589060dc77053d1693a62dff616bb756..d895703d6d678289c8637f4cb8dc8314f252c8b1 100644

--- a/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

+++ b/chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc

@@ -64,7 +64,7 @@ class WebNotificationTrayTest : public InProcessBrowserTest {

void AddNotification(const std::string& id, const std::string& replace_id) {

::Notification notification(GURL("chrome-extension://abbccedd"),

- GURL(),

+ gfx::Image(),

base::ASCIIToUTF16("Test Web Notification"),

base::ASCIIToUTF16(

"Notification message body."),

@@ -80,7 +80,7 @@ class WebNotificationTrayTest : public InProcessBrowserTest {

void UpdateNotification(const std::string& replace_id,

const std::string& new_id) {

::Notification notification(GURL("chrome-extension://abbccedd"),

- GURL(""),

+ gfx::Image(),

base::ASCIIToUTF16("Updated Web Notification"),

base::ASCIIToUTF16("Updated message body."),

blink::WebTextDirectionDefault,