Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1719)

Unified Diff: content/renderer/notification_provider.h

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/notification_provider.h
diff --git a/content/renderer/notification_provider.h b/content/renderer/notification_provider.h
index ab49b073cfbf5ab4a6bb57d19d31bf0942fd7065..eed6c93085128fe0dcb84bdc40106966022f9204 100644
--- a/content/renderer/notification_provider.h
+++ b/content/renderer/notification_provider.h
@@ -5,11 +5,14 @@
#ifndef CONTENT_RENDERER_NOTIFICATION_PROVIDER_H_
#define CONTENT_RENDERER_NOTIFICATION_PROVIDER_H_
+#include "base/memory/scoped_vector.h"
#include "content/public/renderer/render_frame_observer.h"
#include "content/renderer/active_notification_tracker.h"
#include "third_party/WebKit/public/web/WebNotification.h"
#include "third_party/WebKit/public/web/WebNotificationPresenter.h"
+class SkBitmap;
+
namespace content {
// NotificationProvider class is owned by the RenderFrame. Only to be used on
@@ -24,13 +27,21 @@ class NotificationProvider : public RenderFrameObserver,
// RenderFrameObserver implementation.
virtual bool OnMessageReceived(const IPC::Message& message) OVERRIDE;
- // blink::WebNotificationPresenter interface.
+ // blink::WebNotificationPresenter implementation.
virtual bool show(const blink::WebNotification& proxy);
virtual void cancel(const blink::WebNotification& proxy);
virtual void objectDestroyed(const blink::WebNotification& proxy);
virtual blink::WebNotificationPresenter::Permission checkPermission(
const blink::WebSecurityOrigin& origin);
+ // Sends an IPC to the browser process to display the notification identified
+ // by |notification|, accompanied by the downloaded icon.
+ void DisplayNotification(int notification_id, const SkBitmap& icon);
+
+ // Removes the IconDownload object associated with |notification_id|, stopping
+ // any in-progress download. Returns whether the notification was removed.
+ bool RemovePendingNotification(int notification_id);
+
// IPC handlers.
void OnDisplay(int id);
void OnError(int id);
@@ -38,6 +49,12 @@ class NotificationProvider : public RenderFrameObserver,
void OnClick(int id);
void OnNavigate();
+ class IconDownloader;
+
+ // A vector tracking notifications whose icon is still being downloaded.
+ typedef ScopedVector<IconDownloader> PendingNotifications;
+ PendingNotifications pending_notifications_;
+
// A tracker object which manages the active notifications and the IDs
// that are used to refer to them over IPC.
ActiveNotificationTracker manager_;

Powered by Google App Engine
This is Rietveld 408576698