chrome/browser/notifications/notification_test_util.cc - Issue 554213003: Request the icon of a Web Notification in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_test_util.cc

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/notification.cc ('k') | chrome/browser/ui/views/message_center/web_notification_tray_browsertest.cc » ('j') | content/renderer/notification_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/notification_test_util.cc

diff --git a/chrome/browser/notifications/notification_test_util.cc b/chrome/browser/notifications/notification_test_util.cc

index 8abc379376e24312ddb5182ab1b4db2a21a9ce64..49cae3f9522143d66738ac080e975920df2e7645 100644

--- a/chrome/browser/notifications/notification_test_util.cc

+++ b/chrome/browser/notifications/notification_test_util.cc

@@ -15,12 +15,12 @@ content::WebContents* MockNotificationDelegate::GetWebContents() const {

return NULL;

}

+// TODO(peter): |notification_| should be initialized with the correct origin.

StubNotificationUIManager::StubNotificationUIManager(const GURL& welcome_origin)

: notification_(GURL(),

- GURL(),

base::string16(),

- blink::WebTextDirectionDefault,

+ gfx::Image(),

base::string16(),

new MockNotificationDelegate("stub")),