Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1556)

Unified Diff: chrome/browser/notifications/notification.h

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix the tests Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/notifications/notification.h
diff --git a/chrome/browser/notifications/notification.h b/chrome/browser/notifications/notification.h
index 4140f707672592adf247f70a1ad739cef17cf7c3..2027f837b8cb90e1983ec2143e4fbea71e2a6502 100644
--- a/chrome/browser/notifications/notification.h
+++ b/chrome/browser/notifications/notification.h
@@ -22,18 +22,12 @@ class Image;
}
// Representation of a notification to be shown to the user.
-// On non-Ash platforms these are rendered as HTML, sometimes described by a
-// data url converted from text + icon data. On Ash they are rendered as
-// formated text and icon data.
class Notification : public message_center::Notification {
public:
- // Initializes a notification with text content. On non-ash platforms, this
- // creates an HTML representation using a data: URL for display.
Notification(const GURL& origin_url,
- const GURL& icon_url,
const base::string16& title,
const base::string16& body,
- blink::WebTextDirection dir,
+ const gfx::Image& icon,
const base::string16& display_source,
const base::string16& replace_id,
NotificationDelegate* delegate);
@@ -58,9 +52,6 @@ class Notification : public message_center::Notification {
// The origin URL of the script which requested the notification.
const GURL& origin_url() const { return origin_url_; }
- // A url for the icon to be shown (optional).
- const GURL& icon_url() const { return icon_url_; }
-
// A unique identifier used to update (replace) or remove a notification.
const base::string16& replace_id() const { return replace_id_; }
@@ -80,10 +71,6 @@ class Notification : public message_center::Notification {
// The Origin of the page/worker which created this notification.
GURL origin_url_;
- // URL for the icon associated with the notification. Requires delegate_
- // to have a non NULL RenderViewHost.
- GURL icon_url_;
-
// The URLs of the button images for a rich notification.
GURL button_one_icon_url_;
GURL button_two_icon_url_;

Powered by Google App Engine
This is Rietveld 408576698