chrome/browser/notifications/message_center_notification_manager.cc - Issue 554213003: Request the icon of a Web Notification in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notification_manager.cc

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix the tests Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/desktop_notification_service.cc ('k') | chrome/browser/notifications/message_center_notifications_browsertest.cc » ('j') | content/renderer/notification_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notification_manager.cc

diff --git a/chrome/browser/notifications/message_center_notification_manager.cc b/chrome/browser/notifications/message_center_notification_manager.cc

index 5ea8d2421cfbc77b2e2b2057719c3a8437b5d5e2..b0d4ed5e8c1c66c10734b33caa00b3c3f5aa8115 100644

--- a/chrome/browser/notifications/message_center_notification_manager.cc

+++ b/chrome/browser/notifications/message_center_notification_manager.cc

@@ -333,15 +333,6 @@ void MessageCenterNotificationManager::ImageDownloads::StartDownloads(

// In case all downloads are synchronous, assume a pending download.

AddPendingDownload();

- // Notification primary icon.

- StartDownloadWithImage(

- notification,

- &notification.icon(),

- notification.icon_url(),

- base::Bind(&message_center::MessageCenter::SetNotificationIcon,

- base::Unretained(message_center_),

- notification.delegate_id()));

// Notification image.

StartDownloadWithImage(

notification,