chrome/browser/notifications/message_center_notifications_browsertest.cc - Issue 554213003: Request the icon of a Web Notification in the renderer process.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/message_center_notifications_browsertest.cc

Issue 554213003: Request the icon of a Web Notification in the renderer process. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/notifications/message_center_notification_manager.cc ('k') | chrome/browser/notifications/message_center_notifications_unittest.cc » ('j') | content/renderer/notification_provider.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/notifications/message_center_notifications_browsertest.cc

diff --git a/chrome/browser/notifications/message_center_notifications_browsertest.cc b/chrome/browser/notifications/message_center_notifications_browsertest.cc

index 40a3b49ddb953f98ff778163ea609c3f1cd04926..39421a7bb83a43bafa4474c306262a93bb353541 100644

--- a/chrome/browser/notifications/message_center_notifications_browsertest.cc

+++ b/chrome/browser/notifications/message_center_notifications_browsertest.cc

@@ -109,11 +109,11 @@ class MessageCenterNotificationsTest : public InProcessBrowserTest {

new_delegate->AddRef();

}

- return Notification(GURL("chrome-test://testing/"),

- GURL(),

+ GURL origin("chrome-test://testing/");

+ return Notification(origin,

base::ASCIIToUTF16("title"),

base::ASCIIToUTF16("message"),

- blink::WebTextDirectionDefault,

+ gfx::Image(),

base::UTF8ToUTF16("chrome-test://testing/"),

base::UTF8ToUTF16("REPLACE-ME"),

new_delegate);