Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(452)

Issue 554213002: [SyncFS] Run RemoteToLocalSyncer as a background task (Closed)

Created:
6 years, 3 months ago by tzik
Modified:
6 years, 3 months ago
Reviewers:
peria, nhiroki
CC:
chromium-reviews, kinuko+fileapi, nhiroki, tzik, peria
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[SyncFS] Run RemoteToLocalSyncer as a background task BUG=344769 Committed: https://crrev.com/638d2c191d132640597d03926d6a7735f3f85a6f Cr-Commit-Position: refs/heads/master@{#296356}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Patch Set 6 : #

Patch Set 7 : #

Total comments: 6

Patch Set 8 : rebase #

Patch Set 9 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+145 lines, -35 lines) Patch
M chrome/browser/sync_file_system/drive_backend/local_to_remote_syncer.cc View 1 2 3 4 2 chunks +2 lines, -3 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.h View 1 5 chunks +10 lines, -2 lines 0 comments Download
M chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc View 1 2 3 4 5 6 7 8 10 chunks +133 lines, -30 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
tzik
PTL
6 years, 3 months ago (2014-09-12 05:15:56 UTC) #2
nhiroki
LGTM with nits https://codereview.chromium.org/554213002/diff/120001/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc (right): https://codereview.chromium.org/554213002/diff/120001/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc#newcode335 chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:335: // FileMetadata. When it updates FileMetadata ...
6 years, 3 months ago (2014-09-16 08:42:27 UTC) #3
peria
lgtm
6 years, 3 months ago (2014-09-23 12:48:29 UTC) #5
tzik
https://codereview.chromium.org/554213002/diff/120001/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc File chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc (right): https://codereview.chromium.org/554213002/diff/120001/chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc#newcode335 chrome/browser/sync_file_system/drive_backend/remote_to_local_syncer.cc:335: // FileMetadata. When it updates FileMetadata or FileDetais in ...
6 years, 3 months ago (2014-09-24 06:01:49 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/554213002/160001
6 years, 3 months ago (2014-09-24 06:03:12 UTC) #8
commit-bot: I haz the power
Committed patchset #9 (id:160001) as 09ef77b3f082aa0c64d50145c605a417edb27447
6 years, 3 months ago (2014-09-24 06:38:03 UTC) #9
commit-bot: I haz the power
6 years, 3 months ago (2014-09-24 06:38:41 UTC) #10
Message was sent while issue was closed.
Patchset 9 (id:??) landed as
https://crrev.com/638d2c191d132640597d03926d6a7735f3f85a6f
Cr-Commit-Position: refs/heads/master@{#296356}

Powered by Google App Engine
This is Rietveld 408576698