Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(469)

Issue 554203002: Revert "Experimental app list: Remove start page button." (Closed)

Created:
6 years, 3 months ago by Matt Giuca
Modified:
6 years, 3 months ago
Reviewers:
calamity, oshima
CC:
chromium-reviews, chrome-apps-syd-reviews_chromium.org, tfarina, oshima+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@ares-revert-custom-page-on-right
Project:
chromium
Visibility:
Public.

Description

Revert "Experimental app list: Remove start page button." This partially reverts commit 6af9260 (r293066). (But we keep the ability to pass 0 to not have a button.) BUG=406222 Committed: https://crrev.com/8c5d2222d85ac25b328cbbf15e7075fc08b2c2e6 Cr-Commit-Position: refs/heads/master@{#294100}

Patch Set 1 #

Total comments: 3
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M ui/app_list/views/contents_view.cc View 1 chunk +2 lines, -1 line 3 comments Download
A ui/resources/default_100_percent/common/app_list_search_icon.png View Binary file 0 comments Download
A ui/resources/default_200_percent/common/app_list_search_icon.png View Binary file 0 comments Download
M ui/resources/ui_resources.grd View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Matt Giuca
oshima: Sorry about sending you this CL only to send you the revert. We decided ...
6 years, 3 months ago (2014-09-09 08:36:23 UTC) #2
calamity
lgtm https://codereview.chromium.org/554203002/diff/1/ui/app_list/views/contents_view.cc File ui/app_list/views/contents_view.cc (right): https://codereview.chromium.org/554203002/diff/1/ui/app_list/views/contents_view.cc#newcode60 ui/app_list/views/contents_view.cc:60: start_page_view_, IDR_APP_LIST_SEARCH_ICON, NAMED_PAGE_START); I don't think this is ...
6 years, 3 months ago (2014-09-09 09:15:15 UTC) #3
calamity
https://codereview.chromium.org/554203002/diff/1/ui/app_list/views/contents_view.cc File ui/app_list/views/contents_view.cc (right): https://codereview.chromium.org/554203002/diff/1/ui/app_list/views/contents_view.cc#newcode60 ui/app_list/views/contents_view.cc:60: start_page_view_, IDR_APP_LIST_SEARCH_ICON, NAMED_PAGE_START); On 2014/09/09 09:15:15, calamity wrote: > ...
6 years, 3 months ago (2014-09-09 09:16:50 UTC) #4
oshima
lgtm
6 years, 3 months ago (2014-09-09 18:29:30 UTC) #5
Matt Giuca
https://codereview.chromium.org/554203002/diff/1/ui/app_list/views/contents_view.cc File ui/app_list/views/contents_view.cc (right): https://codereview.chromium.org/554203002/diff/1/ui/app_list/views/contents_view.cc#newcode60 ui/app_list/views/contents_view.cc:60: start_page_view_, IDR_APP_LIST_SEARCH_ICON, NAMED_PAGE_START); On 2014/09/09 09:16:50, calamity wrote: > ...
6 years, 3 months ago (2014-09-09 23:45:43 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/554203002/1
6 years, 3 months ago (2014-09-10 01:44:03 UTC) #8
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-10 03:46:31 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mgiuca@chromium.org/554203002/1
6 years, 3 months ago (2014-09-10 03:48:09 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1) as 0665122c827fff9737d05b519746a63dae048465
6 years, 3 months ago (2014-09-10 04:20:37 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 04:26:07 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/8c5d2222d85ac25b328cbbf15e7075fc08b2c2e6
Cr-Commit-Position: refs/heads/master@{#294100}

Powered by Google App Engine
This is Rietveld 408576698