Update the maximize button when size constraints change.

Update the maximize button when size constraints change.

Previously, the maximize button would be hidden if the window is
created with a maxWidth or maxHeight, or non-resizable. Once the size
constraint is removed, the maximize button remains hidden. Similarly,
a size constraint that is applied after the window is created would
not hide the maximize button.

This adds Widget::OnSizeConstraintsChanged which causes the native
widget to update the window's properties, and the non client view to
update the visibility of the maximize button.

BUG=351181, 412241
Committed: https://crrev.com/ec7b3d4ccdd2c2dfdcab68557ca39e5f46099d17
Cr-Commit-Position: refs/heads/master@{#294347}

[jackhou1, 2014-09-09 07:39:26]

jackhou@chromium.org changed reviewers:
+ sky@chromium.org

[jackhou1, 2014-09-09 07:39:27]

sky, could you please review this?

[sky, 2014-09-09 15:42:33]

https://codereview.chromium.org/554183002/diff/1/ui/views/window/custom_frame...
File ui/views/window/custom_frame_view.cc (right):

https://codereview.chromium.org/554183002/diff/1/ui/views/window/custom_frame...
ui/views/window/custom_frame_view.cc:184: void
CustomFrameView::ResetWindowControls() {
Currently ResetWindowControls is:
  // Tells the window controls as rendered by the NonClientView to reset
  // themselves to a normal state. This happens in situations where the
  // containing window does not receive a normal sequences of messages that
  // would lead to the controls returning to this normal state naturally, e.g.
  // when the window is maximized, minimized or restored.

Not you're changing it to mean both this and that the sizeconstraints may have
changed. I think it clearer to keep the existing meaning and add a new function,
SizeConstraintsChanged that gets the new behavior. This way all the existing
ResetWindowControls don't need the additional layout.

[jackhou1, 2014-09-10 00:49:15]

https://codereview.chromium.org/554183002/diff/1/ui/views/window/custom_frame...
File ui/views/window/custom_frame_view.cc (right):

https://codereview.chromium.org/554183002/diff/1/ui/views/window/custom_frame...
ui/views/window/custom_frame_view.cc:184: void
CustomFrameView::ResetWindowControls() {
On 2014/09/09 15:42:32, sky wrote:
> Currently ResetWindowControls is:
>   // Tells the window controls as rendered by the NonClientView to reset
>   // themselves to a normal state. This happens in situations where the
>   // containing window does not receive a normal sequences of messages that
>   // would lead to the controls returning to this normal state naturally, e.g.
>   // when the window is maximized, minimized or restored.
> 
> Not you're changing it to mean both this and that the sizeconstraints may have
> changed. I think it clearer to keep the existing meaning and add a new
function,
> SizeConstraintsChanged that gets the new behavior. This way all the existing
> ResetWindowControls don't need the additional layout.

Done.

Is it okay to have an empty implementation in NonClientFrameView? If you prefer,
I can add leave it abstract like ResetWindowControls and update all the
subclasses.

[sky, 2014-09-10 14:35:57]

As the majority of the functions are pure virtual please keep the new one pure
virtual.
LGTM once done

[jackhou1, 2014-09-11 02:39:20]

jackhou@chromium.org changed reviewers:
+ tapted@chromium.org

[jackhou1, 2014-09-11 02:39:21]

tapted, could you review for OWNERS in apps/

[tapted, 2014-09-11 05:22:22]

ooh nice - apps lgtm

https://codereview.chromium.org/554183002/diff/120001/ui/views/widget/native_...
File ui/views/widget/native_widget_aura.h (right):

https://codereview.chromium.org/554183002/diff/120001/ui/views/widget/native_...
ui/views/widget/native_widget_aura.h:138: virtual void
OnSizeConstraintsChanged() OVERRIDE;
Can you add this to NativeWidgetMac too? It can just be NOTIMPLEMENTED() for now
(I'll add it to my queue) - but it would be nice not to break the compile.

[jackhou1, 2014-09-11 06:28:18]

https://codereview.chromium.org/554183002/diff/120001/ui/views/widget/native_...
File ui/views/widget/native_widget_aura.h (right):

https://codereview.chromium.org/554183002/diff/120001/ui/views/widget/native_...
ui/views/widget/native_widget_aura.h:138: virtual void
OnSizeConstraintsChanged() OVERRIDE;
On 2014/09/11 05:22:22, tapted wrote:
> Can you add this to NativeWidgetMac too? It can just be NOTIMPLEMENTED() for
now
> (I'll add it to my queue) - but it would be nice not to break the compile.

Done.

[jackhou1, 2014-09-11 06:28:28]

The CQ bit was checked by jackhou@chromium.org

[commit-bot: I haz the power, 2014-09-11 06:29:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/554183002/140001

[commit-bot: I haz the power, 2014-09-11 07:34:39]

Committed patchset #8 (id:140001) as b61c836a4cb1345bf63fc15cee439d0370bddd64

[commit-bot: I haz the power, 2014-09-11 07:40:20]

Patchset 8 (id:??) landed as
https://crrev.com/ec7b3d4ccdd2c2dfdcab68557ca39e5f46099d17
Cr-Commit-Position: refs/heads/master@{#294347}