Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Unified Diff: content/renderer/pepper/pepper_try_catch.cc

Issue 554173002: Remove NOTREACHED verifying no previous exceptions are set in PepperTryCatch (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/renderer/pepper/pepper_try_catch.cc
diff --git a/content/renderer/pepper/pepper_try_catch.cc b/content/renderer/pepper/pepper_try_catch.cc
index 0d1aacc97a884a86222b632deebf0bb0ad620c3b..82be7360f5e03239801678aa467b91096a6245b4 100644
--- a/content/renderer/pepper/pepper_try_catch.cc
+++ b/content/renderer/pepper/pepper_try_catch.cc
@@ -109,10 +109,9 @@ void PepperTryCatchV8::ThrowException(const char* message) {
}
void PepperTryCatchV8::SetException(const char* message) {
- if (HasException()) {
- NOTREACHED();
+ if (HasException())
return;
- }
+
exception_ = ppapi::StringVar::StringToPPVar(message);
}
@@ -156,10 +155,9 @@ bool PepperTryCatchVar::HasException() {
}
void PepperTryCatchVar::SetException(const char* message) {
- if (exception_is_set_) {
- NOTREACHED();
+ if (exception_is_set_)
return;
- }
+
if (exception_)
*exception_ = ppapi::StringVar::StringToPPVar(message, strlen(message));
exception_is_set_ = true;
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698