Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(71)

Issue 554173002: Remove NOTREACHED verifying no previous exceptions are set in PepperTryCatch (Closed)

Created:
6 years, 3 months ago by raymes
Modified:
6 years, 3 months ago
CC:
chromium-reviews, darin-cc_chromium.org, jam, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Remove NOTREACHED verifying no previous exceptions are set in PepperTryCatch When setting an exception we check that no other exceptions have been set. However, sometimes it is preferable not to bail out of the codepath immediately because the code becomes messier. In particular, if the context is destroyed, an exception will be set which can happen upon construction of the try/catch. Keeping this NOTREACHED means that we have to check for an exception after the construction of every try/catch. I can't see a problem with not checking the exception immediately - other operations will fail and the result of the try-catch will eventually be set. BUG=303491 Committed: https://crrev.com/36ba52d60b693dfe4980b2b73169988f13251324 Cr-Commit-Position: refs/heads/master@{#294046}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -6 lines) Patch
M content/renderer/pepper/pepper_try_catch.cc View 1 2 chunks +4 lines, -6 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
raymes
6 years, 3 months ago (2014-09-09 03:35:40 UTC) #2
dmichael (off chromium)
lgtm
6 years, 3 months ago (2014-09-09 20:28:57 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/raymes@chromium.org/554173002/20001
6 years, 3 months ago (2014-09-09 23:25:14 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 1dfdcb5fb80c95cf0bf7c51b3dfaa0c8a87e8b84
6 years, 3 months ago (2014-09-10 00:12:38 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:56:50 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/36ba52d60b693dfe4980b2b73169988f13251324
Cr-Commit-Position: refs/heads/master@{#294046}

Powered by Google App Engine
This is Rietveld 408576698