Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 554153003: Revert of [GCM] Adding GCMAccountMapper tests (Closed)

Created:
6 years, 3 months ago by Noel Gordon
Modified:
6 years, 3 months ago
Reviewers:
jianli, fgorski
CC:
chromium-reviews, zea+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Revert of [GCM] Adding GCMAccountMapper tests (patchset #2 id:20001 of https://codereview.chromium.org/544363002/) Reason for revert: GCMAccountMapperTest.MultipleAccountMappings is failing on Win7 Debug. http://build.chromium.org/p/chromium.win/builders/Win7%20Tests%20%28dbg%29%281%29/builds/30987 Original issue's description: > [GCM] Adding GCMAccountMapper tests > > 1) When the status is ADDING (adding message is sent), the token is refreshed. > 2) When the status is REMOVING (removing message is sent), the token is added > again. > 3) updating multiple account mappings > > BUG=374969 > R=jianli@chromium.org > > Committed: https://chromium.googlesource.com/chromium/src/+/a15249de25304c0d2173029bc22b2f136adac537 TBR=jianli@chromium.org,fgorski@chromium.org NOTREECHECKS=true NOTRY=true BUG=374969 Committed: https://crrev.com/185456303fccdc28cd3338661b44457c67607409 Cr-Commit-Position: refs/heads/master@{#293825}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+34 lines, -314 lines) Patch
M components/gcm_driver/gcm_account_mapper_unittest.cc View 22 chunks +34 lines, -314 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Noel Gordon
Created Revert of [GCM] Adding GCMAccountMapper tests
6 years, 3 months ago (2014-09-09 00:49:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/noel@chromium.org/554153003/1
6 years, 3 months ago (2014-09-09 00:52:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 8cd1ffc498b7bb454720f7b16a11dc3f013ebb3c
6 years, 3 months ago (2014-09-09 00:58:01 UTC) #3
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:49:23 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/185456303fccdc28cd3338661b44457c67607409
Cr-Commit-Position: refs/heads/master@{#293825}

Powered by Google App Engine
This is Rietveld 408576698