Don't demote top match for certain match types.

chrome/browser/omnibox/omnibox_field_trial.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/omnibox/omnibox_field_trial.h"
 
 #include <string>
 
 #include "base/metrics/field_trial.h"
 #include "base/strings/string_number_conversions.h"
@@ skipping 247 matching lines @@
       // errors smartly.
       int k, v;
       base::StringToInt(it->first, &k);
       base::StringToInt(it->second, &v);
       (*demotions_by_type)[static_cast<AutocompleteMatchType::Type>(k)] =
           static_cast<float>(v) / 100.0f;
     }
   }
 }
 
+void OmniboxFieldTrial::GetUndemotableTopTypes(
+    AutocompleteInput::PageClassification current_page_classification,
+    UndemotableTopMatchTypes* undemotable_types) {
+  undemotable_types->clear();
+  const std::string types_rule =
+      OmniboxFieldTrial::GetValueForRuleInContext(
+          kUndemotableTopTypeRule,
+          current_page_classification);
+  std::vector<std::string> types;

[Mark P, 2013/11/04 18:47:56]

Please explicitly comment on the format for the value of the rule and what the
value means, a la lines 247-251.

[H Fung, 2013/11/04 19:44:08]

Done.

+  base::SplitString(types_rule, ',', &types);
+  for (std::vector<std::string>::const_iterator it = types.begin();
+       it != types.end(); ++it) {
+    // This is a best-effort conversion; we trust the hand-crafted parameters
+    // downloaded from the server to be perfect.  There's no need for handle
+    // errors smartly.
+    int t;
+    base::StringToInt(*it, &t);
+    undemotable_types->insert(static_cast<AutocompleteMatchType::Type>(t));
+  }
+}
+
 bool OmniboxFieldTrial::ReorderForLegalDefaultMatch(
     AutocompleteInput::PageClassification current_page_classification) {
   return OmniboxFieldTrial::GetValueForRuleInContext(
       kReorderForLegalDefaultMatchRule, current_page_classification) ==
       kReorderForLegalDefaultMatchRuleEnabled;
 }
 
 const char OmniboxFieldTrial::kBundledExperimentFieldTrialName[] =
     "OmniboxBundledExperimentV1";
 const char OmniboxFieldTrial::kShortcutsScoringMaxRelevanceRule[] =
     "ShortcutsScoringMaxRelevance";
 const char OmniboxFieldTrial::kSearchHistoryRule[] = "SearchHistory";
 const char OmniboxFieldTrial::kDemoteByTypeRule[] = "DemoteByType";
+const char OmniboxFieldTrial::kUndemotableTopTypeRule[] = "UndemotableTopTypes";
 const char OmniboxFieldTrial::kReorderForLegalDefaultMatchRule[] =
     "ReorderForLegalDefaultMatch";
 const char OmniboxFieldTrial::kReorderForLegalDefaultMatchRuleEnabled[] =
     "ReorderForLegalDefaultMatch";
 
 // Background and implementation details:
 //
 // Each experiment group in any field trial can come with an optional set of
 // parameters (key-value pairs).  In the bundled omnibox experiment
 // (kBundledExperimentFieldTrialName), each experiment group comes with a
@@ skipping 47 matching lines @@
   if (it != params.end())
     return it->second;
   // Fall back to the global instant extended context.
   it = params.find(rule + ":" + page_classification_str + ":*");
   if (it != params.end())
     return it->second;
   // Look up rule in the global context.
   it = params.find(rule + ":*:*");
   return (it != params.end()) ? it->second : std::string();
 }