Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(309)

Issue 554123003: Add git cl lol. (Closed)

Created:
6 years, 3 months ago by M-A Ruel
Modified:
6 years, 3 months ago
CC:
chromium-reviews, Dirk Pranke, cmp-cc_chromium.org, iannucci+depot_tools_chromium.org
Project:
tools
Visibility:
Public.

Description

Add git cl lol. Because everyone needs humour. Fix a small bug in subcommands.py with undocumented commands. R=stip@chromium.org BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291867

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -1 line) Patch
M git_cl.py View 1 chunk +23 lines, -0 lines 0 comments Download
M subcommand.py View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 7 (2 generated)
M-A Ruel
As requested on irc; http://echelog.com/logs/browse/chromium/1410127200
6 years, 3 months ago (2014-09-08 22:36:14 UTC) #1
ghost stip (do not use)
lgtm, I'd be cool with anything on this site too http://www.retrojunkie.com/asciiart/animals/dinos.htm
6 years, 3 months ago (2014-09-08 22:50:59 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/maruel@chromium.org/554123003/1
6 years, 3 months ago (2014-09-08 22:55:31 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1) as 291867
6 years, 3 months ago (2014-09-08 22:58:30 UTC) #5
jsbell
6 years, 3 months ago (2014-09-10 00:12:15 UTC) #7
Message was sent while issue was closed.
FWIW, the trailing whitespace in the ASCII Art runs afoul of my editor's "delete
trailing whitespace" setting.

I had to disable that setting to work on another patch to git-cl. :(

(Otherwise, I endorse this product and/or service; long time alt.ascii-art
denizen here.)

Powered by Google App Engine
This is Rietveld 408576698