Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: src/objects.cc

Issue 554112: Try to workaround tail call elimination which removes... (Closed) Base URL: http://v8.googlecode.com/svn/branches/experimental/issue555/
Patch Set: Created 10 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/objects.cc
===================================================================
--- src/objects.cc (revision 3727)
+++ src/objects.cc (working copy)
@@ -8320,8 +8320,15 @@
Object* function,
bool runs_in_inner_context,
bool runs_in_outer_context) {
- // Kill the virtual machine.
+ // Try to avoid calling out to another function for breaking here to
+ // avoid tail call elimination when using the Microsoft Visual
+ // Studio compiler which removes the parameters from the stack
+ // trace.
+#if defined(_MSC_VER)
+ __ asm int3;
+#else
OS::Abort();
+#endif
}
} } // namespace v8::internal
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698