Reland of: [Ozone-GBM] Handle GPU crashes

ui/ozone/platform/dri/dri_window_delegate_proxy.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/ozone/platform/dri/dri_window_delegate_proxy.h"
 
 #include "ui/ozone/common/gpu/ozone_gpu_messages.h"
 #include "ui/ozone/platform/dri/gpu_platform_support_host_gbm.h"
 
 namespace ui {
 
 DriWindowDelegateProxy::DriWindowDelegateProxy(
     gfx::AcceleratedWidget widget,
     GpuPlatformSupportHostGbm* sender)
-    : widget_(widget), sender_(sender) {
+    : widget_(widget), sender_(sender), has_connection_(false) {

[spang, 2014/09/08 22:49:17]

Having every window track the connection state seems excessive. Can't you just
add GpuPlatformSupportHostGbm::IsAlive()?

Better yet, why sweat sending message while it's dead at all? You have a
queue...

[dnicoara, 2014/09/09 14:29:28]

Done.
I find the current form to be straight forward since creation of the channel
triggers sending the CreateWindowDelegate message.

[spang, 2014/09/09 14:44:25]

So.. do you still need the queue at all?

[dnicoara, 2014/09/09 15:10:00]

Unfortunately yes, for cursors.

[spang, 2014/09/09 15:21:06]

which reminds me.. we need to set the cursor after a crash, right?

queueing only worked before we handled crashes. It's no longer enough.

 }
 
 DriWindowDelegateProxy::~DriWindowDelegateProxy() {
 }
 
 void DriWindowDelegateProxy::Initialize() {
-  bool status = sender_->Send(new OzoneGpuMsg_CreateWindowDelegate(widget_));
-  DCHECK(status);
+  TRACE_EVENT1("dri", "DriWindowDelegateProxy::Initialize", "widget", widget_);
+  sender_->AddChannelObserver(this);
 }
 
 void DriWindowDelegateProxy::Shutdown() {
+  TRACE_EVENT1("dri", "DriWindowDelegateProxy::Shutdown", "widget", widget_);
+  sender_->RemoveChannelObserver(this);
+  if (!has_connection_)
+    return;
+
   bool status = sender_->Send(new OzoneGpuMsg_DestroyWindowDelegate(widget_));
   DCHECK(status);
 }
 
 gfx::AcceleratedWidget DriWindowDelegateProxy::GetAcceleratedWidget() {
   return widget_;
 }
 
 HardwareDisplayController* DriWindowDelegateProxy::GetController() {
   NOTREACHED();
   return NULL;
 }
 
 void DriWindowDelegateProxy::OnBoundsChanged(const gfx::Rect& bounds) {
+  TRACE_EVENT2("dri",
+               "DriWindowDelegateProxy::OnBoundsChanged",
+               "widget",
+               widget_,
+               "bounds",
+               bounds.ToString());
+  bounds_ = bounds;
+  if (!has_connection_)
+    return;
+
   bool status =
       sender_->Send(new OzoneGpuMsg_WindowBoundsChanged(widget_, bounds));
   DCHECK(status);
 }
 
+void DriWindowDelegateProxy::OnChannelEstablished() {
+  TRACE_EVENT1(
+      "dri", "DriWindowDelegateProxy::OnChannelEstablished", "widget", widget_);
+  has_connection_ = true;
+  bool status = sender_->Send(new OzoneGpuMsg_CreateWindowDelegate(widget_));
+  DCHECK(status);
+  OnBoundsChanged(bounds_);
+}
+
+void DriWindowDelegateProxy::OnChannelDestroyed() {
+  TRACE_EVENT1(
+      "dri", "DriWindowDelegateProxy::OnChannelDestroyed", "widget", widget_);
+  has_connection_ = false;
+}
+
 }  // namespace ui