Issue 554073002: Reland 189a2ed4d209231d517b0e64a722722dead3f17a Fixes HasEventListener check in ExtensionKeybindingR

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554073002: Reland 189a2ed4d209231d517b0e64a722722dead3f17a Fixes HasEventListener check in ExtensionKeybindingR (Closed)

Created:
6 years, 3 months ago by David Tseng

Modified:
6 years, 3 months ago

Reviewers:
David Tseng

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

Reland 189a2ed4d209231d517b0e64a722722dead3f17a Fixes HasEventListener check in ExtensionKeybindingR TBR=dtseng@chromium.org Committed: https://crrev.com/bcc71a377db8638f441d2d2c8b1957ba7e0ee5e9 Cr-Commit-Position: refs/heads/master@{#294014}

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -6 lines)			Patch
	M	chrome/browser/extensions/extension_keybinding_apitest.cc	View	1	1 chunk	+9 lines, -1 line	0 comments	Download
	M	chrome/browser/extensions/extension_keybinding_registry.cc	View		1 chunk	+4 lines, -5 lines	0 comments	Download

Total messages: 5 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/dtseng@chromium.org/554073002/20001

6 years, 3 months ago (2014-09-09 19:58:22 UTC) #3

commit-bot: I haz the power

Committed patchset #2 (id:20001) as 7dc52de73595e4814487bf09b56e823dabcb325c

6 years, 3 months ago (2014-09-09 21:31:08 UTC) #4

commit-bot: I haz the power

6 years, 3 months ago (2014-09-10 03:55:49 UTC) #5

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/bcc71a377db8638f441d2d2c8b1957ba7e0ee5e9
Cr-Commit-Position: refs/heads/master@{#294014}