Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(428)

Unified Diff: pkg/analysis_server/test/services/refactoring/inline_method_test.dart

Issue 554053002: Return a feedback for the INLINE_METHOD refactoring. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/analysis_server/test/edit/refactoring_test.dart ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/analysis_server/test/services/refactoring/inline_method_test.dart
diff --git a/pkg/analysis_server/test/services/refactoring/inline_method_test.dart b/pkg/analysis_server/test/services/refactoring/inline_method_test.dart
index e80622b12ad7ef46ce7fae9cbfa3e255090452c8..c41a5455f53dacf476f7b60dc27c60b59b8be6f6 100644
--- a/pkg/analysis_server/test/services/refactoring/inline_method_test.dart
+++ b/pkg/analysis_server/test/services/refactoring/inline_method_test.dart
@@ -37,10 +37,13 @@ main() {
var res = test(1, 2);
}
''');
- _createRefactoring('test(a, b)');
+ _createRefactoring('test(1, 2)');
// validate state
return refactoring.checkInitialConditions().then((_) {
expect(refactoring.refactoringName, 'Inline Function');
+ expect(refactoring.className, isNull);
+ expect(refactoring.methodName, 'test');
+ expect(refactoring.isDeclaration, isFalse);
});
}
@@ -59,6 +62,9 @@ class A {
// validate state
return refactoring.checkInitialConditions().then((_) {
expect(refactoring.refactoringName, 'Inline Method');
+ expect(refactoring.className, 'A');
+ expect(refactoring.methodName, 'test');
+ expect(refactoring.isDeclaration, isTrue);
});
}
« no previous file with comments | « pkg/analysis_server/test/edit/refactoring_test.dart ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698