Issue 554043004: Fix lsan failure with ManifestParserTest.*

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554043004: Fix lsan failure with ManifestParserTest.* (Closed)

Created:
6 years, 3 months ago by mlamouri (slow - plz ping)

Modified:
6 years, 3 months ago

Reviewers:
Ken Rockot(use gerrit already)

CC:
chromium-reviews, darin-cc_chromium.org, jam, mkwst+moarreviews-content_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Fix lsan failure with ManifestParserTest.* BUG=None TBR=rockot@chromium.org NOTRY=true NOPRESUBMIT=true Committed: https://crrev.com/36816846f1cf8ceea2f96d501ebc745c82349337 Cr-Commit-Position: refs/heads/master@{#294870}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+1 line, -1 line)			Patch
	M	content/renderer/manifest/manifest_parser.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

mlamouri (slow - plz ping)

Committed patchset #1 (id:1) to pending queue manually as 341dd0e (presubmit successful).

6 years, 3 months ago (2014-09-15 19:49:33 UTC) #5

commit-bot: I haz the power

Patchset 1 (id:??) landed as https://crrev.com/36816846f1cf8ceea2f96d501ebc745c82349337 Cr-Commit-Position: refs/heads/master@{#294870}

6 years, 3 months ago (2014-09-15 19:54:17 UTC) #6

mlamouri (slow - plz ping)

6 years, 3 months ago (2014-09-15 20:00:48 UTC) #7

Message was sent while issue was closed.

A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/574433004/ by mlamouri@chromium.org.

The reason for reverting is: broke build.

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages