chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc - Issue 554043003: cros: Create cryptohome keys for Easy sign-in.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc

Issue 554043003: cros: Create cryptohome keys for Easy sign-in. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix use-after-free Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/about_flags.cc ('k') | chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.h » ('j') | chrome/browser/chromeos/login/easy_unlock/easy_unlock_create_keys_operation.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc

diff --git a/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc b/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc

index afd886381e41e00d938b25e26c428e10821c0fce..3ce6375ec6ba060140dbd6001282e3fd1c921fe4 100644

--- a/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc

+++ b/chrome/browser/chromeos/login/auth/cryptohome_authenticator_unittest.cc

@@ -266,16 +266,12 @@ class CryptohomeAuthenticatorTest : public testing::Test {

key_data_.front()->authorization_types.push_back(

cryptohome::RetrievedKeyData::AUTHORIZATION_TYPE_HMACSHA256);

if (key_type) {

- scoped_ptr<cryptohome::RetrievedKeyData::ProviderData> provider_data(

- new cryptohome::RetrievedKeyData::ProviderData("type"));

- provider_data->number = key_type.Pass();

- key_data_.front()->provider_data.push_back(provider_data.release());

+ key_data_.front()->provider_data.push_back(

+ cryptohome::ProviderDataEntry("type", *key_type));

}

if (salt) {

- scoped_ptr<cryptohome::RetrievedKeyData::ProviderData> provider_data(

- new cryptohome::RetrievedKeyData::ProviderData("salt"));

- provider_data->bytes = salt.Pass();

- key_data_.front()->provider_data.push_back(provider_data.release());

+ key_data_.front()->provider_data.push_back(

+ cryptohome::ProviderDataEntry("salt", *salt));

}

EXPECT_CALL(*mock_homedir_methods_, GetKeyDataEx(

cryptohome::Identification(user_context_.GetUserID()),