Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issue 554033003: Revert of allow canvas to force conservative clips (for speed) (Closed)

Created:
6 years, 3 months ago by reed1
Modified:
6 years, 3 months ago
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Project:
skia
Visibility:
Public.

Description

Revert of allow canvas to force conservative clips (for speed) (patchset #7 id:120001 of https://codereview.chromium.org/541593005/) Reason for revert: multipicturedraw failed on nvprmsaa -- don't know why yet Original issue's description: > Allow SkCanvas to be initialized to force conservative rasterclips. This has the following effects: > > 1. Queries to the current clip will be conservatively large. This can mean the quickReject may return false more often. > > 2. The conservative clips mean less work is done. > > 3. Enabled by default for Gpu, Record, and NoSaveLayer canvases. > > 4. API is private for now. > > Committed: https://skia.googlesource.com/skia/+/27a5e656c3d6ef22f9cb34de18e1b960da3aa241 TBR=robertphillips@google.com,bsalomon@google.com,mtklein@google.com,junov@google.com NOTREECHECKS=true NOTRY=true Committed: https://skia.googlesource.com/skia/+/6f09709519b79a1159f3826645f1c5fbc101ee11

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+171 lines, -238 lines) Patch
M include/core/SkCanvas.h View 3 chunks +6 lines, -11 lines 0 comments Download
M include/core/SkDevice.h View 1 chunk +0 lines, -2 lines 0 comments Download
M include/gpu/SkGpuDevice.h View 1 chunk +0 lines, -1 line 0 comments Download
M include/utils/SkNoSaveLayerCanvas.h View 2 chunks +16 lines, -2 lines 0 comments Download
M src/core/SkCanvas.cpp View 13 chunks +115 lines, -74 lines 0 comments Download
M src/core/SkDeviceLooper.cpp View 1 chunk +3 lines, -4 lines 0 comments Download
M src/core/SkPictureRecord.cpp View 2 chunks +4 lines, -2 lines 0 comments Download
M src/core/SkRasterClip.h View 4 chunks +3 lines, -7 lines 0 comments Download
M src/core/SkRasterClip.cpp View 8 chunks +16 lines, -126 lines 0 comments Download
M src/core/SkRecorder.cpp View 2 chunks +3 lines, -3 lines 0 comments Download
M tests/AAClipTest.cpp View 2 chunks +3 lines, -4 lines 0 comments Download
M tests/PictureTest.cpp View 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
Created Revert of allow canvas to force conservative clips (for speed)
6 years, 3 months ago (2014-09-09 19:50:18 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/reed@google.com/554033003/1
6 years, 3 months ago (2014-09-09 19:50:55 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1) as 6f09709519b79a1159f3826645f1c5fbc101ee11
6 years, 3 months ago (2014-09-09 19:51:27 UTC) #3
reed2
A revert of this CL (patchset #1 id:1) has been created in https://codereview.chromium.org/560713002/ by reed@chromium.org. ...
6 years, 3 months ago (2014-09-10 01:45:10 UTC) #4
bsalomon
On 2014/09/10 01:45:10, reed2 wrote: > A revert of this CL (patchset #1 id:1) has ...
6 years, 3 months ago (2014-09-10 13:49:52 UTC) #5
bsalomon
6 years, 3 months ago (2014-09-10 13:49:54 UTC) #6
Message was sent while issue was closed.
On 2014/09/10 01:45:10, reed2 wrote:
> A revert of this CL (patchset #1 id:1) has been created in
> https://codereview.chromium.org/560713002/ by mailto:reed@chromium.org.
> 
> The reason for reverting is: May just rebaseline, plus want to see the results
> of the chrome tests, so re-trying this CL..

There was a nice perf improvement picked up by the alerting mechanism on
skiaperf.com:

http://skiaperf.com/cl/44

Powered by Google App Engine
This is Rietveld 408576698