Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(11)

Issue 554004: GTK: Use GTK+ theme selection colors and plumb them into webkit. (Closed)

Created:
9 years, 5 months ago by Elliot Glaysher
Modified:
8 years, 2 months ago
CC:
chromium-reviews_googlegroups.com, brettw+cc_chromium.org, darin (slow to review), jam, ben+cc_chromium.org, pam+watch_chromium.org
Visibility:
Public.

Description

GTK: Use GTK+ theme selection colors and plumb them into webkit. [Chromium side of patch] BUG=25831 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=37193

Patch Set 1 #

Total comments: 2

Patch Set 2 : Add chromium specific layout test #

Patch Set 3 : Move layout tests to correct paths #

Messages

Total messages: 8 (0 generated)
Elliot Glaysher
After test driving this patch, chrome linux with a GTK theme without selection colors looks ...
9 years, 5 months ago (2010-01-19 22:37:36 UTC) #1
Evan Martin
LGTM I suggest merging your two patches into one for ease of review. On the ...
9 years, 5 months ago (2010-01-19 22:44:35 UTC) #2
Evan Stade
lgtm2
9 years, 5 months ago (2010-01-19 22:55:43 UTC) #3
Elliot Glaysher
http://codereview.chromium.org/554004/diff/1/2 File chrome/browser/gtk/gtk_theme_provider.cc (right): http://codereview.chromium.org/554004/diff/1/2#newcode627 chrome/browser/gtk/gtk_theme_provider.cc:627: inactive_selection_fg_color_ = SkColorSetRGB(50, 50, 50); On 2010/01/19 22:44:35, Evan ...
9 years, 5 months ago (2010-01-19 23:44:45 UTC) #4
Elliot Glaysher
On 2010/01/19 22:44:35, Evan Martin wrote: > On the WebKit > side you'll need a ...
9 years, 5 months ago (2010-01-20 00:09:00 UTC) #5
Evan Martin
On Tue, Jan 19, 2010 at 4:09 PM, <erg@chromium.org> wrote: > I am confused about ...
9 years, 5 months ago (2010-01-20 00:17:26 UTC) #6
Elliot Glaysher
Updated with layout tests on this side, and uploaded webkit side of patch to https://bugs.webkit.org/show_bug.cgi?id=33921
9 years, 5 months ago (2010-01-20 23:11:33 UTC) #7
dglazkov
9 years, 3 months ago (2010-03-19 23:42:57 UTC) #8
Dudes, you landed the test on chromium side! :)

Powered by Google App Engine
This is Rietveld 408576698