Issue 554003: (Mac) Intercept (Cocoa) cursor setting by plugins and forward it on properly....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 554003: (Mac) Intercept (Cocoa) cursor setting by plugins and forward it on properly.... (Closed)

Created:
10 years, 11 months ago by Avi (use Gerrit)

Modified:
9 years, 7 months ago

Reviewers:
stuartmorgan

CC:
chromium-reviews_googlegroups.com, John Grabowski, darin (slow to review), jam, pam+watch_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

(Mac) Intercept (Cocoa) cursor setting by plugins and forward it on properly. BUG=http://crbug.com/20717 TEST=as in bug; this covers new Flash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=36554

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Patch Set 3 : '' #

Created: 10 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -5 lines)			Patch
M	chrome/plugin/plugin_interpose_util_mac.mm	View	1	3 chunks	+20 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl.h	View		1 chunk	+3 lines, -1 line	0 comments	Download
M	webkit/glue/plugins/webplugin_delegate_impl_mac.mm	View		1 chunk	+4 lines, -0 lines	0 comments	Download
M	webkit/glue/webcursor.h	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	webkit/glue/webcursor_mac.mm	View	1 2	3 chunks	+52 lines, -3 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stuartmorgan

LGTM http://codereview.chromium.org/554003/diff/12/15 File webkit/glue/webcursor_mac.mm (right): http://codereview.chromium.org/554003/diff/12/15#newcode253 webkit/glue/webcursor_mac.mm:253: cursor_info.type = WebCursorInfo::TypePointer; Why not let this use ...

10 years, 11 months ago (2010-01-19 21:16:20 UTC) #2

Avi (use Gerrit)

On 2010/01/19 21:16:20, stuartmorgan wrote: > Why not let this use the customImage path? Good ...

10 years, 11 months ago (2010-01-19 21:31:21 UTC) #3

LGTM

Expand Messages | Collapse Messages