Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 553983010: ServiceWorker: Implement navigator.serviceWorker.getRegistration [1/3] (Closed)

Created:
6 years, 3 months ago by Kunihiko Sakamoto
Modified:
6 years, 3 months ago
Reviewers:
tkent, nhiroki, horo
CC:
blink-reviews, jamesr, dglazkov+blink, abarth-chromium
Project:
blink
Visibility:
Public.

Description

ServiceWorker: Implement navigator.serviceWorker.getRegistration [1/3] This is the first step towards implementing getRegistration method of ServiceWorkerContainer. This patch adds definition of the method and its callback type to WebServiceWorkerProvider. [2/3] https://codereview.chromium.org/535753002/ [3/3] https://codereview.chromium.org/540823003/ BUG=404951 TEST=compile (tests will be added by subsequent patches) Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=181784

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M public/platform/WebServiceWorkerProvider.h View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (5 generated)
Kunihiko Sakamoto
6 years, 3 months ago (2014-09-09 07:26:10 UTC) #2
nhiroki
lgtm
6 years, 3 months ago (2014-09-10 03:08:23 UTC) #3
horo
lgtm
6 years, 3 months ago (2014-09-10 07:34:19 UTC) #4
Kunihiko Sakamoto
+tkent for OWNERS review
6 years, 3 months ago (2014-09-10 08:19:33 UTC) #6
tkent
lgtm
6 years, 3 months ago (2014-09-10 23:37:43 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/553983010/1
6 years, 3 months ago (2014-09-10 23:38:26 UTC) #9
commit-bot: I haz the power
Try jobs failed on following builders: win_blink_rel on tryserver.blink (http://build.chromium.org/p/tryserver.blink/builders/win_blink_rel/builds/26524)
6 years, 3 months ago (2014-09-11 01:56:40 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/553983010/1
6 years, 3 months ago (2014-09-11 01:59:56 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-11 02:41:15 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as 181784

Powered by Google App Engine
This is Rietveld 408576698