Add copy support in inliner.

Add copy support in inliner.

Refactors JSGraph to ensure that the zone operators are created in
can be different from the Graph's zone.

R=mstarzinger@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=23804

[sigurds, 2014-09-08 11:06:53]

sigurds@chromium.org changed reviewers:
+ mstarzinger@chromium.org

[sigurds, 2014-09-08 11:06:53]

PTAL.

[Michael Starzinger, 2014-09-08 17:38:52]

Looking good. There are many test cases that don't actually need the
operator-builders. Could we leave them NULL in those test cases to reduce the
number of moving parts? WDYT?

[sigurds, 2014-09-09 08:56:38]

After personal discussion with you and bmeurer, I think we should not pass NULL
arguments to JSGraph in unit tests that don't use that component.

[Michael Starzinger, 2014-09-09 11:52:15]

LGTM if comments are addressed.

https://codereview.chromium.org/553873002/diff/40001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/553873002/diff/40001/src/compiler/js-inlining...
src/compiler/js-inlining.cc:70: // InlineAtCall will create some new nodes using
{graph}'s builders (and hence
nit: The last sentence of the comment is slightly out of date, let's adapt it.

https://codereview.chromium.org/553873002/diff/40001/src/compiler/js-inlining...
src/compiler/js-inlining.cc:219: JSGraph* target_graph_;
I think the target_graph_ should be of type "Graph*" as well. The only place
where we need the original type graph is to create the operator for the
sentinel. Could we either just use NULL as the operator of the sentinel or pass
in one constant sentinel operator from the outside?

[sigurds, 2014-09-09 13:20:26]

Committed patchset #5 (id:80001) manually as 23804 (presubmit successful).

[sigurds, 2014-09-15 10:29:09]

https://codereview.chromium.org/553873002/diff/40001/src/compiler/js-inlining.cc
File src/compiler/js-inlining.cc (right):

https://codereview.chromium.org/553873002/diff/40001/src/compiler/js-inlining...
src/compiler/js-inlining.cc:70: // InlineAtCall will create some new nodes using
{graph}'s builders (and hence
On 2014/09/09 11:52:15, Michael Starzinger wrote:
> nit: The last sentence of the comment is slightly out of date, let's adapt it.

Done.

https://codereview.chromium.org/553873002/diff/40001/src/compiler/js-inlining...
src/compiler/js-inlining.cc:219: JSGraph* target_graph_;
On 2014/09/09 11:52:15, Michael Starzinger wrote:
> I think the target_graph_ should be of type "Graph*" as well. The only place
> where we need the original type graph is to create the operator for the
> sentinel. Could we either just use NULL as the operator of the sentinel or
pass
> in one constant sentinel operator from the outside?

Done.