Issue 553843003: Print Preview UI tweaks

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 553843003: Print Preview UI tweaks (Closed)

Created:
6 years, 3 months ago by Aleksey Shlyapnikov

Modified:
6 years, 3 months ago

Reviewers:
Vitaly Buka (NO REVIEWS)

CC:
chromium-reviews, arv+watch_chromium.org

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Project:
chromium

Visibility:
Public.

More Reviews

Description

Print Preview UI tweaks: - change "More/Fewer options" -> "More/Fewer settings" - change "More/Fewer settings" button background color to #f6f6f6 BUG=397741 Committed: https://crrev.com/c478e9cca565f659a5b18a35fccee1a60e4ed807 Cr-Commit-Position: refs/heads/master@{#294316}

Patch Set 1 #

Created: 6 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+3 lines, -3 lines)			Patch
	M	chrome/app/generated_resources.grd	View		1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/resources/print_preview/settings/more_settings.css	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 7 (2 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/553843003/1

6 years, 3 months ago (2014-09-11 02:25:04 UTC) #5

commit-bot: I haz the power

Committed patchset #1 (id:1) as 39dc92d4fb7dbf2484f3bb11a51ba6537490d88b

6 years, 3 months ago (2014-09-11 03:45:36 UTC) #6

commit-bot: I haz the power

6 years, 3 months ago (2014-09-11 04:00:12 UTC) #7

Message was sent while issue was closed.

Patchset 1 (id:??) landed as
https://crrev.com/c478e9cca565f659a5b18a35fccee1a60e4ed807
Cr-Commit-Position: refs/heads/master@{#294316}

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages