Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(112)

Issue 553793002: Explicit declare gbm library directory (Closed)

Created:
6 years, 3 months ago by vignatti (out of this project)
Modified:
6 years, 3 months ago
Reviewers:
dnicoara, brettw, spang
CC:
chromium-reviews, ozone-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Explicit declare gbm library directory We are checking gbm system library and cflags using pkg, therefore its directory ought to be checked in the same way. I spotted this problem in a Ubuntu 12.04 system where my custom pkg directory is rather clean, without superfluous libraries. Probably no other developer noticed this bug before because in the working pkg directory was already being pulled in by libgestures or any other configuration that uses --libs-only-L in system.gyp. BUG=none TEST=embedded=1 ozone_platform_gbm=1, linking content_shell Committed: https://crrev.com/5cdbf79d872e2bbdcf8994da76ef156bc9bacbbc Cr-Commit-Position: refs/heads/master@{#293903}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M build/linux/system.gyp View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (2 generated)
vignatti (out of this project)
brettw@ PTAL.
6 years, 3 months ago (2014-09-08 07:48:59 UTC) #2
dnicoara
lgtm
6 years, 3 months ago (2014-09-08 13:34:24 UTC) #3
brettw
lgtm
6 years, 3 months ago (2014-09-08 20:08:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tiago.vignatti@intel.com/553793002/1
6 years, 3 months ago (2014-09-09 07:41:26 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1) as 77daf708e63e8b2d5e39ba80e794ea98af5e879c
6 years, 3 months ago (2014-09-09 09:19:07 UTC) #7
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:52:14 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/5cdbf79d872e2bbdcf8994da76ef156bc9bacbbc
Cr-Commit-Position: refs/heads/master@{#293903}

Powered by Google App Engine
This is Rietveld 408576698