Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 553783007: Add support for CHROMIUM_OUT_DIR to findbugs util. (Closed)

Created:
6 years, 3 months ago by nyquist
Modified:
6 years, 3 months ago
CC:
chromium-reviews, klundberg+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Add support for CHROMIUM_OUT_DIR to findbugs util. Currently, the findbugs_diff.py and friends ignore the CHROMIUM_OUT_DIR environment variable, and hardcodes the out folder to just be 'out'. This is problematic for developers who use a different out folder. This CL makes the generic findbugs util library read the environment variable, and then default to 'out' if it is not set. BUG=None Committed: https://crrev.com/bb78a46883c8b9a3201b6e2e457dda93de8b7072 Cr-Commit-Position: refs/heads/master@{#293990}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -1 line) Patch
M build/android/pylib/utils/findbugs.py View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 9 (3 generated)
nyquist
6 years, 3 months ago (2014-09-09 17:11:02 UTC) #2
nyquist
aurimas: PTAL
6 years, 3 months ago (2014-09-09 17:47:15 UTC) #4
aurimas (slooooooooow)
lgtm
6 years, 3 months ago (2014-09-09 18:17:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nyquist@chromium.org/553783007/1
6 years, 3 months ago (2014-09-09 18:21:28 UTC) #7
commit-bot: I haz the power
Committed patchset #1 (id:1) as aedc5f51a21f5df027c0bbd99f8f305ac0575d1c
6 years, 3 months ago (2014-09-09 19:47:03 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:55:02 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb78a46883c8b9a3201b6e2e457dda93de8b7072
Cr-Commit-Position: refs/heads/master@{#293990}

Powered by Google App Engine
This is Rietveld 408576698