Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3274)

Unified Diff: base/win/shortcut.h

Issue 553783005: Remove the IShellLink::Resolve step in ResolveShortcutProperties. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: update comment Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | base/win/shortcut.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/win/shortcut.h
diff --git a/base/win/shortcut.h b/base/win/shortcut.h
index 13940ed52c464eb932ef79fc031900e0a25c31af..2feb4c3aa9edb633cc0fd338da6536955b9f682c 100644
--- a/base/win/shortcut.h
+++ b/base/win/shortcut.h
@@ -125,14 +125,16 @@ BASE_EXPORT bool CreateOrUpdateShortcutLink(
const ShortcutProperties& properties,
ShortcutOperation operation);
-// Resolves Windows shortcut (.LNK file)
+// Resolves Windows shortcut (.LNK file).
// This methods tries to resolve selected properties of a shortcut .LNK file.
// The path of the shortcut to resolve is in |shortcut_path|. |options| is a bit
// field composed of ShortcutProperties::IndividualProperties, to specify which
// properties to read. It should be non-0. The resulting data are read into
-// |properties|, which must not be NULL. The function returns true if all
-// requested properties are successfully read. Otherwise some reads have failed
-// and intermediate values written to |properties| should be ignored.
+// |properties|, which must not be NULL. Note: PROPERTIES_TARGET will retrieve
+// the target path as stored in the shortcut but won't attempt to resolve that
+// path so it may not be valid. The function returns true if all requested
+// properties are successfully read. Otherwise some reads have failed and
+// intermediate values written to |properties| should be ignored.
BASE_EXPORT bool ResolveShortcutProperties(const FilePath& shortcut_path,
uint32 options,
ShortcutProperties* properties);
« no previous file with comments | « no previous file | base/win/shortcut.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698