Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issue 553783003: Swap sdefresne for blundell as temporary OWNERS of history (Closed)

Created:
6 years, 3 months ago by sdefresne
Modified:
6 years, 3 months ago
Reviewers:
brettw, blundell
CC:
chromium-reviews, browser-components-watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : Swap sdefresne for blundell as temporary OWNERS of history #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M chrome/browser/history/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download
M components/OWNERS View 1 2 1 chunk +1 line, -1 line 0 comments Download
M components/history/OWNERS View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
sdefresne
brettw: Please take a look. blundell: OWNERS of //components
6 years, 3 months ago (2014-09-08 08:55:45 UTC) #2
blundell
LGTM I think you should just replace me with you.
6 years, 3 months ago (2014-09-08 09:00:41 UTC) #3
sdefresne
brettw: friendly ping.
6 years, 3 months ago (2014-09-17 17:00:16 UTC) #4
brettw
lgtm
6 years, 3 months ago (2014-09-17 20:12:30 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/553783003/20001
6 years, 3 months ago (2014-09-18 08:03:08 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: mac_gpu on tryserver.chromium.gpu (http://build.chromium.org/p/tryserver.chromium.gpu/builders/mac_gpu/builds/57575) ios_dbg_simulator on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_dbg_simulator/builds/16187) ios_rel_device ...
6 years, 3 months ago (2014-09-18 08:06:13 UTC) #9
sdefresne
On 2014/09/18 08:06:13, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-18 08:11:27 UTC) #10
commit-bot: I haz the power
Patchset 3 (id:??) landed as https://crrev.com/f101461327246e5fa9b6d5e89a3e57563e662e0b Cr-Commit-Position: refs/heads/master@{#295434}
6 years, 3 months ago (2014-09-18 08:11:58 UTC) #11
sdefresne
6 years, 3 months ago (2014-09-18 08:12:05 UTC) #12
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as f101461 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698