Rework app list item drag zones.

ui/app_list/views/apps_grid_view_unittest.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ui/app_list/views/apps_grid_view.h"
 
 #include <string>
 
 #include "base/basictypes.h"
 #include "base/command_line.h"
@@ skipping 409 matching lines @@
   // This test assumes Folders are enabled.
   EnsureFoldersEnabled();
 
   size_t kTotalItems = 2;
   model_->PopulateApps(kTotalItems);
   EXPECT_EQ(2u, model_->top_level_item_list()->item_count());
   EXPECT_EQ(std::string("Item 0,Item 1"), model_->GetModelContent());
 
   gfx::Point from = GetItemTileRectAt(0, 1).CenterPoint();
   int reorder_offset = (GetItemTileRectAt(0, 1).CenterPoint() -
-                        GetItemTileRectAt(0, 0).CenterPoint()).Length() -
-                       kReorderDroppingCircleRadius - kGridIconDimension / 2 +
-                       5;
+                        GetItemTileRectAt(0, 0).origin()).Length();
   gfx::Point to = gfx::Point(from.x() - reorder_offset, from.y());
 
   // Dragging item_1 closing to item_0 should leads to re-ordering these two
   // items.
   SimulateDrag(AppsGridView::MOUSE, from, to);
   apps_grid_view_->EndDrag(false);
   EXPECT_EQ(2u, model_->top_level_item_list()->item_count());
   EXPECT_EQ(std::string("Item 1,Item 0"), model_->GetModelContent());
   test_api_->LayoutToIdealBounds();
 }

[tapted, 2014/09/11 08:08:55]

I think you need to add more here - at least to cover some of the possibilities
of `dir`

[calamity, 2014/09/15 03:26:11]

Added a couple. Any other cases you can think of that are worth testing?

[tapted, 2014/09/15 06:12:53]

That's good i think - I think you've got most of the corner cases

 
 TEST_F(AppsGridViewTest, MouseDragFolderReorder) {
   EnsureFoldersEnabled();
 
   size_t kTotalItems = 2;
   model_->CreateAndPopulateFolderWithApps(kTotalItems);
   model_->PopulateAppWithId(kTotalItems);
   EXPECT_EQ(2u, model_->top_level_item_list()->item_count());
   EXPECT_EQ(AppListFolderItem::kItemType,
             model_->top_level_item_list()->item_at(0)->GetItemType());
@@ skipping 253 matching lines @@
   AppListItemView* item_view = GetItemViewAt(0);
   ASSERT_TRUE(item_view);
   const views::Label* title_label = item_view->title();
   EXPECT_FALSE(title_label->GetTooltipText(
       title_label->bounds().CenterPoint(), &actual_tooltip));
   EXPECT_EQ(title, base::UTF16ToUTF8(title_label->text()));
 }
 
 }  // namespace test
 }  // namespace app_list