Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(294)

Issue 553743002: Enable logging from Chromoting client plugin in PNaCl. (Closed)

Created:
6 years, 3 months ago by Sergey Ulanov
Modified:
6 years, 3 months ago
Reviewers:
Wez
CC:
chromium-reviews, chromoting-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Enable logging from Chromoting client plugin in PNaCl. Now all LOG() messages are forwarded from the PNaCl plugin to the webapp. Previously this feature was enabled only for native Debug builds. Committed: https://crrev.com/0f1683a8611c7677dc0cf6a797d4bb108e6f113f Cr-Commit-Position: refs/heads/master@{#293893}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M remoting/client/plugin/chromoting_instance.cc View 1 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
Sergey Ulanov
I don't have access to http://crbug.com/253624 , but from what I remember it should be ...
6 years, 3 months ago (2014-09-08 05:44:57 UTC) #2
Wez
On 2014/09/08 05:44:57, Sergey Ulanov wrote: > I don't have access to http://crbug.com/253624 , but ...
6 years, 3 months ago (2014-09-08 18:31:57 UTC) #3
Sergey Ulanov
On 2014/09/08 18:31:57, Wez wrote: > On 2014/09/08 05:44:57, Sergey Ulanov wrote: > > I ...
6 years, 3 months ago (2014-09-08 20:27:33 UTC) #4
Wez
Oh, of course! Missed the #ifdef! LGTM
6 years, 3 months ago (2014-09-08 20:45:12 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sergeyu@chromium.org/553743002/20001
6 years, 3 months ago (2014-09-09 02:05:21 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 699bc4c6ec20d221a7b0866dafa366ad9096ea27
6 years, 3 months ago (2014-09-09 08:01:29 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:51:54 UTC) #9
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0f1683a8611c7677dc0cf6a797d4bb108e6f113f
Cr-Commit-Position: refs/heads/master@{#293893}

Powered by Google App Engine
This is Rietveld 408576698