Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(150)

Issue 553693002: Move ui:unittests target into ui/base/BUILD.gn (Closed)

Created:
6 years, 3 months ago by tfarina
Modified:
6 years, 3 months ago
Reviewers:
brettw, sky
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Move ui:unittests target into ui/base/BUILD.gn With commit 2148b92f9cc676bf2b64dc7e47ef65daac393031, ui_unittests is now in ui/base/ui_base_tests.gyp. To mirror this change in GN, we moved the unittests target into ui/base/BUILD.gn BUG=331829, 373148, 299841, 103304 TEST=gn gen out/Debug_gn && ninja -C out/Debug_gn ui/base:unittests R=brettw@chromium.org,sky@chromium.org Committed: https://crrev.com/d22dcfddb2f40bff1f226dbd31ac63518ca20033 Cr-Commit-Position: refs/heads/master@{#293960}

Patch Set 1 #

Patch Set 2 : android fix #

Patch Set 3 : lets see #

Patch Set 4 : fix android?? #

Patch Set 5 : fix for Android. Now for real. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+198 lines, -179 lines) Patch
M BUILD.gn View 1 2 3 4 2 chunks +1 line, -3 lines 0 comments Download
D ui/BUILD.gn View 1 chunk +0 lines, -176 lines 0 comments Download
M ui/base/BUILD.gn View 1 2 3 4 1 chunk +196 lines, -0 lines 0 comments Download
M ui/base/ui_base_tests.gyp View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (3 generated)
tfarina
6 years, 3 months ago (2014-09-07 17:51:23 UTC) #1
brettw
lgtm
6 years, 3 months ago (2014-09-07 21:19:30 UTC) #2
tfarina
Brett, could you look again? How come android is building ui_unittests after my changes?
6 years, 3 months ago (2014-09-08 02:21:53 UTC) #3
brettw
On 2014/09/08 02:21:53, tfarina wrote: > Brett, could you look again? > > How come ...
6 years, 3 months ago (2014-09-08 17:35:32 UTC) #4
tfarina
Done.
6 years, 3 months ago (2014-09-09 02:36:53 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/553693002/80001
6 years, 3 months ago (2014-09-09 02:55:22 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presubmit/builds/9572)
6 years, 3 months ago (2014-09-09 08:10:23 UTC) #9
tfarina
On 2014/09/09 08:10:23, I haz the power (commit-bot) wrote: > Try jobs failed on following ...
6 years, 3 months ago (2014-09-09 16:36:59 UTC) #10
sky
LGTM
6 years, 3 months ago (2014-09-09 17:10:25 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/553693002/80001
6 years, 3 months ago (2014-09-09 17:17:49 UTC) #13
commit-bot: I haz the power
Committed patchset #5 (id:80001) as 5cc0a096e4f99be18880ac6a75556880cf57c113
6 years, 3 months ago (2014-09-09 17:22:58 UTC) #14
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:54:04 UTC) #15
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/d22dcfddb2f40bff1f226dbd31ac63518ca20033
Cr-Commit-Position: refs/heads/master@{#293960}

Powered by Google App Engine
This is Rietveld 408576698