Enables docked windows by default

ash/display/screen_position_controller.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "ash/display/screen_position_controller.h"
 
 #include "ash/display/display_controller.h"
 #include "ash/root_window_controller.h"
 #include "ash/shell.h"
 #include "ash/shell_window_ids.h"
@@ skipping 174 matching lines @@
       aura::client::ActivationClient* activation_client =
           aura::client::GetActivationClient(window->GetRootWindow());
       aura::Window* active = activation_client->GetActiveWindow();
 
       aura::WindowTracker tracker;
       if (focused)
         tracker.Add(focused);
       if (active && focused != active)
         tracker.Add(active);
 
+      // Adjust the bounds before reparenting since the bounds may be taken
+      // into consideration to ensure window visibility when it gets added
+      // to layout.
+      if (window->type() != aura::client::WINDOW_TYPE_POPUP) {
+        gfx::Point origin(bounds.origin());
+        const gfx::Point display_origin =
+            Shell::GetScreen()->GetDisplayNearestWindow(
+                dst_container).bounds().origin();
+        origin.Offset(-display_origin.x(), -display_origin.y());
+        gfx::Rect new_bounds(gfx::Rect(origin, bounds.size()));
+        window->SetBounds(new_bounds);
+      }

[flackr, 2013/11/01 16:52:28]

This doesn't look related to simply enabling docked windows, separate bug?

[varkha, 2013/11/05 20:34:23]

Done. https://codereview.chromium.org/57963003/

       dst_container->AddChild(window);
 
       MoveAllTransientChildrenToNewRoot(display, window);
 
       // Restore focused/active window.
       if (tracker.Contains(focused)) {
         aura::client::GetFocusClient(window)->FocusWindow(focused);
         // TODO(beng): replace with GetRootWindow().
         ash::Shell::GetInstance()->set_target_root_window(
             focused->GetDispatcher());
       } else if (tracker.Contains(active)) {
         activation_client->ActivateWindow(active);
       }
+      if (window->type() != aura::client::WINDOW_TYPE_POPUP)
+        return;
     }
   }
 
   gfx::Point origin(bounds.origin());
   const gfx::Point display_origin = Shell::GetScreen()->GetDisplayNearestWindow(
       window).bounds().origin();
   origin.Offset(-display_origin.x(), -display_origin.y());
   window->SetBounds(gfx::Rect(origin, bounds.size()));
 }
 
 }  // internal
 }  // ash