Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4287)

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc

Issue 55363003: Send compressed histograms with system logs when sending feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase with grt's changes Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc
diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc b/chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc
index 53afb1cd56233c476f6859420bef97b2f709cd20..aba5489e39dc99310ce20d5bb19508a1fcd1ceaf 100644
--- a/chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc
+++ b/chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc
@@ -6,6 +6,7 @@
#include "base/callback.h"
#include "base/memory/weak_ptr.h"
+#include "base/metrics/statistics_recorder.h"
#include "base/values.h"
#include "chrome/browser/chromeos/login/user_manager.h"
#include "chrome/browser/chromeos/system_logs/scrubbed_system_logs_fetcher.h"
@@ -24,6 +25,7 @@ class FeedbackServiceImpl
virtual std::string GetUserEmail() OVERRIDE;
virtual void GetSystemInformation(
const GetSystemInformationCallback& callback) OVERRIDE;
+ virtual void GetHistograms(std::string* histograms) OVERRIDE;
private:
void ProcessSystemLogs(scoped_ptr<chromeos::SystemLogsResponse> sys_info);
@@ -62,6 +64,10 @@ void FeedbackServiceImpl::GetSystemInformation(
AsWeakPtr()));
}
+void FeedbackServiceImpl::GetHistograms(std::string* histograms) {
+ *histograms = base::StatisticsRecorder::ToJSON(std::string());
+}
+
void FeedbackServiceImpl::ProcessSystemLogs(
scoped_ptr<chromeos::SystemLogsResponse> sys_info_map) {
SystemInformationList sys_info_list;

Powered by Google App Engine
This is Rietveld 408576698