Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1110)

Unified Diff: chrome/browser/feedback/feedback_data.h

Issue 55363003: Send compressed histograms with system logs when sending feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebase Created 7 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/feedback/feedback_data.h
diff --git a/chrome/browser/feedback/feedback_data.h b/chrome/browser/feedback/feedback_data.h
index 49a66430d64c2dd7b7554e018801810944c59642..bc566f5f9cd352a97007b84e8a06bfbbc8538952 100644
--- a/chrome/browser/feedback/feedback_data.h
+++ b/chrome/browser/feedback/feedback_data.h
@@ -36,13 +36,20 @@ class FeedbackData : public base::RefCountedThreadSafe<FeedbackData> {
// compression.
void SetAndCompressSystemInfo(scoped_ptr<SystemLogsMap> sys_info);
- // Sets the system information for this instance and kicks off its
+ // Sets the histograms for this instance and kicks off its
// compression.
+ void SetAndCompressHistograms(scoped_ptr<std::string> histograms);
+
+ // Sets the attached file data and kicks off its compression.
void AttachAndCompressFileData(scoped_ptr<std::string> attached_filedata);
// Called once we have compressed our system logs.
void OnCompressLogsComplete(scoped_ptr<std::string> compressed_logs);
+ // Called once we have compressed our histograms.
+ void OnCompressHistogramsComplete(
+ scoped_ptr<std::string> compressed_histograms);
+
// Called once we have compressed our attached file.
void OnCompressFileComplete(scoped_ptr<std::string> compressed_file);
@@ -68,6 +75,10 @@ class FeedbackData : public base::RefCountedThreadSafe<FeedbackData> {
int trace_id() const { return trace_id_; }
SystemLogsMap* sys_info() const { return sys_info_.get(); }
std::string* compressed_logs() const { return compressed_logs_.get(); }
+ std::string* histograms() const { return histograms_.get(); }
+ std::string* compressed_histograms() const {
+ return compressed_histograms_.get();
+ }
// Setters
void set_profile(Profile* profile) { profile_ = profile; }
@@ -119,8 +130,13 @@ class FeedbackData : public base::RefCountedThreadSafe<FeedbackData> {
scoped_ptr<SystemLogsMap> sys_info_;
scoped_ptr<std::string> compressed_logs_;
+ scoped_ptr<std::string> histograms_;
+ scoped_ptr<std::string> compressed_histograms_;
+
+ // TODO(rkc): Refactor compressing logic into a simpler common implementation.
bool feedback_page_data_complete_;
bool syslogs_compression_complete_;
+ bool histograms_compression_complete_;
bool attached_file_compression_complete_;
bool report_sent_;

Powered by Google App Engine
This is Rietveld 408576698