chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc - Issue 55363003: Send compressed histograms with system logs when sending feedback.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

Issue 55363003: Send compressed histograms with system logs when sending feedback. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Unit test Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/feedback_private/feedback_service_chromeos.cc ('k') | chrome/browser/extensions/extension_function_histogram_value.h » ('j') | chrome/browser/feedback/feedback_data.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

diff --git a/chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc b/chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

index 0bc35b00ae28cbd2470de1095d4fbb06b7b7f4c7..27425516cfcdfa6744d44d54988b47ae407823c9 100644

--- a/chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

+++ b/chrome/browser/extensions/api/feedback_private/feedback_service_nonchromeos.cc

@@ -34,6 +34,7 @@ class FeedbackServiceImpl

virtual std::string GetUserEmail() OVERRIDE;

virtual void GetSystemInformation(

const GetSystemInformationCallback& callback) OVERRIDE;

+ virtual void GetHistograms(std::string*) OVERRIDE;

Alexei Svitkine (slow) 2013/11/04 15:26:40 Nit: name the param

michaelpg 2013/11/04 17:25:18 Done.

private:

// Overridden from FeedbackService:

@@ -82,6 +83,9 @@ void FeedbackServiceImpl::GetSystemInformation(

system_information_callback_.Run(sys_info_list);

}

+void FeedbackServiceImpl::GetHistograms(std::string* histograms) {

base::WeakPtr<FeedbackService> FeedbackServiceImpl::GetWeakPtr() {

return AsWeakPtr();

}